This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Rework how we handle xed to link xed directly into libhpcrun.so and#574
Merged
Conversation
libhpcrun.o. This allows us to hide the xed symbols inside our library in case the application also uses xed. This now requires xed to be built statically (.a) with fPIC.
Member
Author
|
I tested (1) and (2) above, so "safe" to merge. |
jmellorcrummey
pushed a commit
that referenced
this pull request
May 16, 2022
…574) libhpcrun.o. This allows us to hide the xed symbols inside our library in case the application also uses xed. This now requires xed to be built statically (.a) with fPIC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libhpcrun.o. This allows us to hide the xed symbols inside our
library in case the application also uses xed.
This now requires xed to be built statically (.a) with fPIC.
@jmellorcrummey This is the fix for the xed symbol clash.
Before merging into something, I want to test three things: