This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Unwind clean 2017#8
Merged
unkadoug merged 98 commits intoHPCToolkit:masterfrom Sep 7, 2017
unkadoug:unwind-clean-2017
Merged
Conversation
and the comments don't really say what it means.
… consists of a start and an end already. Discard a couple of unused/redundant functions.
…nction, except for one parameter, so discard one of the implementations.
…ecipe_map.c, or delete them.
the former is nonzero if and only if the latter is set. So eliminate the latter and test n_trolls in the one place where trolled was tested before.
…ebug functions which aren't really useless.
the first argument to new_ui.
to new_ui instead of passing individual register values.
…ation evaluations of UWI_RECIPE.
…e latest restored canonical in interval_arg_t, and search forward from there when doing canonical updates instead of walking backward to the latest marked canonical.
Conflicts: src/tool/hpcrun/unwind/common/binarytree_uwi.c src/tool/hpcrun/unwind/common/binarytree_uwi.h src/tool/hpcrun/unwind/x86-family/x86-and.c src/tool/hpcrun/unwind/x86-family/x86-build-intervals.c src/tool/hpcrun/unwind/x86-family/x86-lea.c src/tool/hpcrun/unwind/x86-family/x86-move.c src/tool/hpcrun/unwind/x86-family/x86-unwind-interval.c
mess up my memory allocator. Undo that.
but are used, even uninitialized, in common/backtrace.c.
Currently, the definition of unw_word_t for native code unwinding is incompatible with the definition libunwind uses, making blending the two methods difficult.
same way it is set for x86 and ppc unwinding.
from cursor for libunwind. Fill in the cursor fence field for libunwind, so that when backtrace.c copies the value, there will be a value to copy.
for a procedure ends before the end of the procedure, by raising its upper bound to match the end of the procedure. Otherwise, we may complete build_intervals and find that the lookup for the interval containing the instruction address fails. Return the status from the libunwind call as the status from the build_intervals call.
jmellorcrummey
approved these changes
Sep 7, 2017
Conflicts: src/tool/hpcrun/unwind/x86-family/x86-validate-retn-addr.c
This was referenced Oct 30, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache libunwind recipes in the skip list, when using libunwind. Get rid of extra allocations and extra pointer dereferencing. Clean up code elsewhere.