Ab#569:Fix wait leg circle color and alignment#5832
Merged
Merged
Conversation
vesameskanen
requested changes
May 22, 2026
Comment on lines
25
to
27
| const isFirstChild = () => { | ||
| return !isNotFirstLeg && index === 0 && !viaType; | ||
| }; |
Member
There was a problem hiding this comment.
Please refactor this too - there is no reason to declare this kind of function. Maybe add a comment when the condition is needed later in code.
Comment on lines
+172
to
+173
| ItineraryCircleLineWithIcon.defaultProps = { | ||
| viaType: null, |
Member
There was a problem hiding this comment.
We do not want to use default props any more. Check for example LegInfo.
vesameskanen
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ItineryCircleLineWithIconfrom class component to function componentPull Request Check List
Review