This repository was archived by the owner on Dec 31, 2023. It is now read-only.
Jdurrell/ec single class deletion #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stan29308
approved these changes
Mar 15, 2021
stan29308
force-pushed
the
jdurrell/EC-single-class-deletion
branch
from
f072eef to
32493aa
Compare
Contributor
|
For integration testing, I forgot to do user.js so someone will have to do that eventually |
jdurrell
added a commit
that referenced
this pull request
Sep 7, 2023
Co-authored-by: Stan <stanleykwok61@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few questions for this one:
Is https://api.hackpsu.org/v2/doc/#api-User-Remove_Extra_Credit_Assignment already supposed to cover this functionality? It looks like it was intended to, but it doesn't look like it actually does. If it was supposed to, then I can copy this functionality into where it's supposed to be instead of creating a new api endpoint for it.
Is there anything else I need to do to actually publish a new endpoint?
Does this need integration tests attached to it? I added a unit test for generating the correct SQL, but the other extra credit functions didn't have integration tests, so I skipped that for this one.