This repository was archived by the owner on Dec 31, 2023. It is now read-only.
Jdurrell/error on duplicate checkin #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurrell
added a commit
that referenced
this pull request
Apr 8, 2022
* Jdurrell/fix 400 could not find image error (#183) * Prod Push (#170) Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: jdurrell <john.m.durrell.gmail.com> Co-authored-by: John <john.m.durrell@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * remove incorrect 400 error message * changed image bucket to hackpsu18.appspot.com Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * workshop-pin-capability-added-pending-update (#180) * workshop-pin-capability-added-pending-update * cleaning up copy-paste bloat and implementing infrastructure * updated changes for john * fixed data mapper and scanner * update for john * route integration tests * documentation and datamapper tests * bruh, this didn't even compile at first * fixed permissions, missing idtoken, pin checking, and invalid pin tests * added workshop scans to test data * fixed insertion of scans * fixed get-by-pin integration tests not querying the correct pin * added option for pin relative to current hackathon Co-authored-by: jdurrell <john.m.durrell@gmail.com> * Correcting Documentation "IllegalArgumentErrors" is undefined. Correct use is "IllegalArgumentError" * Correcting the documentation error (#190) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Correcting the documentation error (#191) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Minor change so I can merge to master (#194) * Dummy change so I can merge into master (#196) * Update RSVP Date (#200) * update rsvp date * update location to ag sci * Include whether someone is driving to the event in registration fields (#202) * include driving-to-event in registration fields * fix registration data mapper tests (even though they totally worked on my machine even though they shouldn't have wtf typescript) * fix registration processor test * normalise driving boolean (#204) * Dummy change for merging purposes * add mobile push notification route (#207) * add mobile push notification route * make cloud function route a static variable * input checking for title and message * unit tests for mobile notification error checking * check for null firebase custom claims * check for null firebase custom claims (#209) * check for null firebase custom claims * fix custom claims checks * stupid merge * Jdurrell/notification for check in (#211) * check for null firebase custom claims * stupid merge * push notification for checking in to workshop * Jdurrell/error on duplicate checkin (#213) * check for null firebase custom claims * stupid merge * reject duplicate workshop checkin * Jdurrell/idtoken header checkin notification call (#214) * update group to admin * set idtoken in header * missed a semicolon that could have broken stuff * travis plz Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> Co-authored-by: tcorrellpsu <71111189+tcorrellpsu@users.noreply.github.com>
jdurrell
added a commit
that referenced
this pull request
Apr 9, 2022
* Jdurrell/fix 400 could not find image error (#183) * Prod Push (#170) Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: jdurrell <john.m.durrell.gmail.com> Co-authored-by: John <john.m.durrell@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * remove incorrect 400 error message * changed image bucket to hackpsu18.appspot.com Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * workshop-pin-capability-added-pending-update (#180) * workshop-pin-capability-added-pending-update * cleaning up copy-paste bloat and implementing infrastructure * updated changes for john * fixed data mapper and scanner * update for john * route integration tests * documentation and datamapper tests * bruh, this didn't even compile at first * fixed permissions, missing idtoken, pin checking, and invalid pin tests * added workshop scans to test data * fixed insertion of scans * fixed get-by-pin integration tests not querying the correct pin * added option for pin relative to current hackathon Co-authored-by: jdurrell <john.m.durrell@gmail.com> * Correcting Documentation "IllegalArgumentErrors" is undefined. Correct use is "IllegalArgumentError" * Correcting the documentation error (#190) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Correcting the documentation error (#191) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Minor change so I can merge to master (#194) * Dummy change so I can merge into master (#196) * Update RSVP Date (#200) * update rsvp date * update location to ag sci * Include whether someone is driving to the event in registration fields (#202) * include driving-to-event in registration fields * fix registration data mapper tests (even though they totally worked on my machine even though they shouldn't have wtf typescript) * fix registration processor test * normalise driving boolean (#204) * Dummy change for merging purposes * add mobile push notification route (#207) * add mobile push notification route * make cloud function route a static variable * input checking for title and message * unit tests for mobile notification error checking * check for null firebase custom claims * check for null firebase custom claims (#209) * check for null firebase custom claims * fix custom claims checks * stupid merge * Jdurrell/notification for check in (#211) * check for null firebase custom claims * stupid merge * push notification for checking in to workshop * Jdurrell/error on duplicate checkin (#213) * check for null firebase custom claims * stupid merge * reject duplicate workshop checkin * Jdurrell/idtoken header checkin notification call (#214) * update group to admin * set idtoken in header * missed a semicolon that could have broken stuff * travis plz * get registration by email * actually publish the route Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> Co-authored-by: tcorrellpsu <71111189+tcorrellpsu@users.noreply.github.com>
jdurrell
added a commit
that referenced
this pull request
Sep 7, 2023
* check for null firebase custom claims * stupid merge * reject duplicate workshop checkin
jdurrell
added a commit
that referenced
this pull request
Sep 7, 2023
* Jdurrell/fix 400 could not find image error (#183) * Prod Push (#170) Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: jdurrell <john.m.durrell.gmail.com> Co-authored-by: John <john.m.durrell@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * remove incorrect 400 error message * changed image bucket to hackpsu18.appspot.com Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * workshop-pin-capability-added-pending-update (#180) * workshop-pin-capability-added-pending-update * cleaning up copy-paste bloat and implementing infrastructure * updated changes for john * fixed data mapper and scanner * update for john * route integration tests * documentation and datamapper tests * bruh, this didn't even compile at first * fixed permissions, missing idtoken, pin checking, and invalid pin tests * added workshop scans to test data * fixed insertion of scans * fixed get-by-pin integration tests not querying the correct pin * added option for pin relative to current hackathon Co-authored-by: jdurrell <john.m.durrell@gmail.com> * Correcting Documentation "IllegalArgumentErrors" is undefined. Correct use is "IllegalArgumentError" * Correcting the documentation error (#190) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Correcting the documentation error (#191) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Minor change so I can merge to master (#194) * Dummy change so I can merge into master (#196) * Update RSVP Date (#200) * update rsvp date * update location to ag sci * Include whether someone is driving to the event in registration fields (#202) * include driving-to-event in registration fields * fix registration data mapper tests (even though they totally worked on my machine even though they shouldn't have wtf typescript) * fix registration processor test * normalise driving boolean (#204) * Dummy change for merging purposes * add mobile push notification route (#207) * add mobile push notification route * make cloud function route a static variable * input checking for title and message * unit tests for mobile notification error checking * check for null firebase custom claims * check for null firebase custom claims (#209) * check for null firebase custom claims * fix custom claims checks * stupid merge * Jdurrell/notification for check in (#211) * check for null firebase custom claims * stupid merge * push notification for checking in to workshop * Jdurrell/error on duplicate checkin (#213) * check for null firebase custom claims * stupid merge * reject duplicate workshop checkin * Jdurrell/idtoken header checkin notification call (#214) * update group to admin * set idtoken in header * missed a semicolon that could have broken stuff * travis plz Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> Co-authored-by: tcorrellpsu <71111189+tcorrellpsu@users.noreply.github.com>
jdurrell
added a commit
that referenced
this pull request
Sep 7, 2023
* Jdurrell/fix 400 could not find image error (#183) * Prod Push (#170) Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: jdurrell <john.m.durrell.gmail.com> Co-authored-by: John <john.m.durrell@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * remove incorrect 400 error message * changed image bucket to hackpsu18.appspot.com Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> * workshop-pin-capability-added-pending-update (#180) * workshop-pin-capability-added-pending-update * cleaning up copy-paste bloat and implementing infrastructure * updated changes for john * fixed data mapper and scanner * update for john * route integration tests * documentation and datamapper tests * bruh, this didn't even compile at first * fixed permissions, missing idtoken, pin checking, and invalid pin tests * added workshop scans to test data * fixed insertion of scans * fixed get-by-pin integration tests not querying the correct pin * added option for pin relative to current hackathon Co-authored-by: jdurrell <john.m.durrell@gmail.com> * Correcting Documentation "IllegalArgumentErrors" is undefined. Correct use is "IllegalArgumentError" * Correcting the documentation error (#190) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Correcting the documentation error (#191) "IllegalArgumentErrors" is undefined, and should be "IllegalArgumentError" * Minor change so I can merge to master (#194) * Dummy change so I can merge into master (#196) * Update RSVP Date (#200) * update rsvp date * update location to ag sci * Include whether someone is driving to the event in registration fields (#202) * include driving-to-event in registration fields * fix registration data mapper tests (even though they totally worked on my machine even though they shouldn't have wtf typescript) * fix registration processor test * normalise driving boolean (#204) * Dummy change for merging purposes * add mobile push notification route (#207) * add mobile push notification route * make cloud function route a static variable * input checking for title and message * unit tests for mobile notification error checking * check for null firebase custom claims * check for null firebase custom claims (#209) * check for null firebase custom claims * fix custom claims checks * stupid merge * Jdurrell/notification for check in (#211) * check for null firebase custom claims * stupid merge * push notification for checking in to workshop * Jdurrell/error on duplicate checkin (#213) * check for null firebase custom claims * stupid merge * reject duplicate workshop checkin * Jdurrell/idtoken header checkin notification call (#214) * update group to admin * set idtoken in header * missed a semicolon that could have broken stuff * travis plz * get registration by email * actually publish the route Co-authored-by: Rahul Ramkumar <rahulram226@gmail.com> Co-authored-by: Stan <stanleykwok61@gmail.com> Co-authored-by: stan29308 <35966427+stan29308@users.noreply.github.com> Co-authored-by: tcorrellpsu <71111189+tcorrellpsu@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.