Fix inconsistent methodology/skills catalog references flagged in review#1930
Merged
Fix inconsistent methodology/skills catalog references flagged in review#1930
Conversation
…reconcile SKILLS.md +4-since-2026-02-20 summary Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/6b48542c-bf9f-4b3e-875b-861ed38c2bb1 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pethers
April 22, 2026 09:59
View session
github-actions
Bot
added
documentation
Contributor
🏷️ Automatic Labeling SummaryThis PR has been automatically labeled based on the files changed and PR metadata. Applied Labels: documentation,skill,size-xs Label Categories
For more information, see |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two documentation inconsistencies by aligning prose “delta summaries” with the authoritative tables already present in the docs (analysis methodology split and skills catalog “NEW” entries).
Changes:
- Update
analysis/README.mdto list the correct set of the 5 non-core methodology documents (out of 11 total). - Update
SKILLS.mdfooter to name the four skills actually marked ✨ NEW with date 2026-04-22.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| analysis/README.md | Adjusts the “remaining 5 methodology files” list to match the core-vs-non-core split described elsewhere in the doc. |
| SKILLS.md | Corrects the footer’s “+4 since 2026-02-20” skill names to match the catalog’s NEW-dated entries. |
| | Move/rename files | Produce "placeholder" analysis that looks real | | ||
|
|
||
| **The AI agent reads the 6 core methodology guides (of 11 total) and the 8 core output templates (of 23 total), reads the actual data, and produces genuine analytical content based on evidence found in the documents.** The remaining 5 methodology files (electoral-domain, political-style-guide, strategic-extensions, structural-metadata, ai-driven-analysis-guide) provide domain-specific and meta-methodology context; the remaining 15 templates cover Tier-C aggregation (scenario-analysis, executive-brief, coalition-mathematics, election-2026-analysis, historical-parallels, comparative-international, devils-advocate, forward-indicators, implementation-feasibility, intelligence-assessment, media-framing-analysis, methodology-reflection, voter-segmentation, data-download-manifest, cross-reference-map). | ||
| **The AI agent reads the 6 core methodology guides (of 11 total) and the 8 core output templates (of 23 total), reads the actual data, and produces genuine analytical content based on evidence found in the documents.** The remaining 5 methodology files (electoral-domain, per-document, strategic-extensions, structural-metadata, synthesis) provide domain-specific and meta-methodology context; the remaining 15 templates cover Tier-C aggregation (scenario-analysis, executive-brief, coalition-mathematics, election-2026-analysis, historical-parallels, comparative-international, devils-advocate, forward-indicators, implementation-feasibility, intelligence-assessment, media-framing-analysis, methodology-reflection, voter-segmentation, data-download-manifest, cross-reference-map). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation inconsistencies from pullrequestreview-4153674252: the "remaining 5" methodology list contradicted the core-methodology table, and the SKILLS.md delta summary named skills that aren't flagged NEW in the catalog.
Changes
analysis/README.md— the "remaining 5 methodology files" list includedai-driven-analysis-guide(core 🟠 Bump actions/upload-artifact from 4.6.2 to 6.0.0 #6) andpolitical-style-guide(core 🟠 [StepSecurity] Apply security best practices #5). Replaced with the actually non-core files so the split matches the Methodology Documents table (11 total − 6 core = 5 remaining):electoral-domain,per-document,strategic-extensions,structural-metadata,synthesisSKILLS.md— the "+4 since 2026-02-20" footer namedseo-best-practices,global-government-analysis,investigative-journalism,myndigheter-monitoring, but only the first is marked ✨ NEW (2026-04-22) in the numbered catalog. Reconciled to the four entries actually dated 2026-04-22:business-model-canvas,mcp-gateway-configuration,mcp-gateway-security,seo-best-practicesNo structural/count changes; both edits are one-line substitutions aligning prose with the authoritative tables already present in each file.