Fixing empty dashboards and ensuring data loads by Copilot · Pull Request #2407 · Hack23/riksdagsmonitor

Copilot · 2026-05-11T09:28:33Z

…shboard pages Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/13182c9a-238b-4723-a6d6-5d5c9e5443e8 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/13182c9a-238b-4723-a6d6-5d5c9e5443e8 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-11T09:29:41Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: javascript,performance,testing,refactor,size-l

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-05-11T09:30:18Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

github-actions · 2026-05-11T09:46:31Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

This PR addresses a production regression where pre-rendered dashboard HTML pages shipped a dev-only module script path (/src/browser/main.ts), causing dashboards to render empty in S3/CloudFront. It does so by extending the staticPagesPlugin to rewrite module script tags to hashed production bundles and by adding regression tests in both unit and Cypress suites.

Changes:

Extend scripts/vite-plugin-static-pages.js to rewrite <script type="module" src="/src/browser/<name>.ts"> to the hashed /assets/js/<name>-<hash>.js bundle (using the Vite manifest or a dist scan fallback).
Add Vitest unit tests covering module-script rewrite scenarios (manifest lookup, fallback scan, no-op when unresolved, non-matching tags).
Strengthen Cypress dashboard assertions to detect missing JS execution (Chart.js instance attachment) and verify served HTML contains hashed bundle paths.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vite.config.js	Updates build comments explaining why dashboard pages require module-script rewriting to avoid empty dashboards in production.
scripts/vite-plugin-static-pages.js	Implements module `<script>` tag rewriting (manifest-backed + fallback scan) and logs rewrite counts.
tests/vite-plugin-static-pages.test.ts	Adds unit coverage for the new module-script rewrite behavior and fallbacks.
cypress/support/commands.js	Improves `waitForChart` to verify real Chart.js runtime attachment, not just canvas dimensions.
cypress/e2e/dashboards.cy.js	Adds regression tests ensuring dashboard pages ship hashed `main-*.js` bundles and that `window.Chart` is registered at runtime.

+ * We only match the canonical absolute `/src/browser/<name>.ts` form (the
+ * only one used in this codebase). Captures: 1=before-attrs, 2=name,
+ * 3=after-attrs.
+ */
+const MODULE_SCRIPT_RE =
+  /<script\b([^>]*?)\bsrc\s*=\s*"\/src\/browser\/([A-Za-z0-9_-]+)\.ts"([^>]*)>\s*<\/script>/gi;


+              const attrsBefore = before.replace(/\bsrc\s*=\s*"[^"]*"/i, '').trim();
+              const attrsAfter = after.replace(/\bsrc\s*=\s*"[^"]*"/i, '').trim();


@@ -284,11 +284,16 @@ export default defineConfig({
          // (parties, anomaly-detection, network-analysis, voting-cohesion,
          // momentum, coalitions, seasonal-patterns, pre-election, ministers,
          // risk, election-cycle, committees) × 14 languages = 126 files,
-          // emitted by scripts/build-dashboard-pages.py. They are pure
-          // static HTML that loads existing chart bundles via root-relative
-          // <script src="/assets/js/...">, so they don't need to be Rollup
-          // entry points — staticPagesPlugin just copies them to dist/ and
-          // rewrites the styles.css link to the hashed asset.
+          // emitted by scripts/build-dashboard-pages.py.


github-actions · 2026-05-11T11:02:25Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…e2e tests Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/6f0effac-0d1b-43cb-9f66-a6536d6be7a9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

…t.js assertions Root cause: live site served /src/browser/main.ts (dev path) instead of hashed /assets/js/main-*.js. S3/CloudFront returns index.html for unknown paths with text/html, browser silently rejects HTML as JS module → no lazy loader → no charts → empty dashboards. Changes: - Add deploy-s3.yml pre-flight: verify all 9 dashboard HTML files have hashed bundle and no dev paths before deploying - Add tests/dashboard-bundle-integrity.test.ts: validates dist/ output post-build (30 new assertions) - Fix all-dashboards.cy.js: replace weak canvas.width>0 checks with Chart.getChart() verification (proves full pipeline: main.ts loaded → register-globals → dashboard module → CSV fetched → chart rendered) - Add cia-data directory verification to deploy workflow Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/6f0effac-0d1b-43cb-9f66-a6536d6be7a9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

pethers · 2026-05-11T12:35:49Z

@copilot resolve the merge conflicts in this pull request must get all from main

…hboards Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-05-11T12:44:04Z

@copilot resolve the merge conflicts in this pull request must get all from main

Merged main into this branch using -X theirs to accept all changes from main. The merge commit 70900be has 2 parents (53ad92e + 5ff3e07), 0 conflict markers, and all 5461 tests pass.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2026-05-11T12:48:00Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

+/**
+ * Match a single `<script type="module" src="/src/browser/<name>.ts">` dev
+ * tag (the one Vite expects in source) so we can rewrite it to the hashed
+ * production bundle (`/assets/js/<name>-<hash>.js`) emitted by Rollup.
+ *


@@ -284,11 +284,16 @@ export default defineConfig({
          // (parties, anomaly-detection, network-analysis, voting-cohesion,
          // momentum, coalitions, seasonal-patterns, pre-election, ministers,
          // risk, election-cycle, committees) × 14 languages = 126 files,
-          // emitted by scripts/build-dashboard-pages.py. They are pure
-          // static HTML that loads existing chart bundles via root-relative
-          // <script src="/assets/js/...">, so they don't need to be Rollup
-          // entry points — staticPagesPlugin just copies them to dist/ and
-          // rewrites the styles.css link to the hashed asset.
+          // emitted by scripts/build-dashboard-pages.py.


pethers · 2026-05-11T13:03:11Z

@copilot apply changes based on the comments in this thread and fix Test Dashboard / Dashboard Tests (cypress/e2e/dashboards.cy.js) (pull_request)
Test Dashboard / Dashboard Tests (cypress/e2e/dashboards.cy.js) (pull_request)Failing after 2m

Improve e2e test of dashboards, improve all

- Tighten MODULE_SCRIPT_RE to require type="module" (lookahead) so a classic <script src="/src/browser/main.ts"> can never be silently rewritten to a hashed ESM bundle (would throw at runtime). - Strip pre-existing crossorigin attribute from before/after captures so the rewritten <script> never emits duplicate crossorigin="" attributes. - vite.config.js dashboards comment: list the 9 actual dashboard slugs (anomaly-detection, coalitions, committees, election-cycle, ministers, parties, pre-election, risk, seasonal-patterns) so 9×14=126 math holds. - cypress/e2e/dashboards.cy.js "should render charts after data loads": scrollIntoView() the #party-dashboard container before waitForChart so the IntersectionObserver-based lazy loader fires and registerBrowserGlobals attaches Chart.js to window.Chart (root cause of CI failure). - Add 2 regression tests: duplicate-crossorigin avoidance + classic <script> non-rewrite (16/16 vite-plugin-static-pages tests passing). Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/8f896bbf-f838-4686-95c6-8707b2651b9f Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-05-11T13:09:55Z

@copilot apply changes based on the comments in this thread and fix [Test Dashboard / Dashboard Test...

Done in 2e3737f:

MODULE_SCRIPT_RE now requires type="module" via lookahead (classic <script> tags are no longer silently rewritten to a hashed ESM bundle).
Rewriter strips any pre-existing crossorigin from before/after captures so the output never carries duplicate attributes.
vite.config.js dashboards comment fixed to list the 9 actual slugs (was 12, breaking the 9×14=126 math).
Cypress dashboards.cy.js "should render charts after data loads" now scrollIntoView()s #party-dashboard before waitForChart, so the IntersectionObserver-based lazy loader fires and registerBrowserGlobals() attaches Chart.js to window.Chart (root cause of the CI timeout).
Added 2 regression tests in tests/vite-plugin-static-pages.test.ts (16/16 passing): duplicate-crossorigin avoidance + classic <script> non-rewrite.

github-actions · 2026-05-11T13:13:59Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot AI and others added 2 commits May 11, 2026 09:21

fix(static-pages): rewrite /src/browser/main.ts → hashed bundle in da…

d4791ef

…shboard pages Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/13182c9a-238b-4723-a6d6-5d5c9e5443e8 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Changes before error encountered

7bc99a1

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/13182c9a-238b-4723-a6d6-5d5c9e5443e8 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI assigned Copilot and pethers May 11, 2026

Copilot created this pull request from a session on behalf of pethers May 11, 2026 09:28 View session

Copilot started work on behalf of pethers May 11, 2026 09:29 View session

github-actions Bot added javascript JavaScript code changes performance Performance optimization testing Test coverage refactor Code refactoring size-l Large change (250-1000 lines) labels May 11, 2026

Copilot AI requested a review from pethers May 11, 2026 09:34

Copilot started work on behalf of pethers May 11, 2026 09:36 View session

Copilot finished work on behalf of pethers May 11, 2026 09:41

Merge branch 'main' into copilot/fix-empty-dashboards

85b4e3c

pethers marked this pull request as ready for review May 11, 2026 09:44

Copilot AI review requested due to automatic review settings May 11, 2026 09:44

Copilot started reviewing on behalf of pethers May 11, 2026 09:46 View session

Copilot started work on behalf of pethers May 11, 2026 09:47 View session

Copilot started work on behalf of pethers May 11, 2026 09:52 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Copilot started work on behalf of pethers May 11, 2026 10:43 View session

Copilot started work on behalf of pethers May 11, 2026 10:50 View session

github-actions Bot added rtl RTL language support (Arabic, Hebrew) news News articles and content generation labels May 11, 2026

github-actions Bot added the size-xl Extra large change (> 1000 lines) label May 11, 2026

Copilot started work on behalf of pethers May 11, 2026 11:55 View session

Copilot AI and others added 2 commits May 11, 2026 12:18

Analyze and fix empty dashboards: add build verification and improve …

1f3f27b

…e2e tests Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/6f0effac-0d1b-43cb-9f66-a6536d6be7a9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions Bot added workflow GitHub Actions workflows ci-cd CI/CD pipeline changes deployment Deployment configuration labels May 11, 2026

Copilot finished work on behalf of pethers May 11, 2026 12:25

Copilot started work on behalf of pethers May 11, 2026 12:36 View session

Merge remote-tracking branch 'origin/main' into copilot/fix-empty-das…

70900be

…hboards Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers May 11, 2026 12:45

pethers requested a review from Copilot May 11, 2026 12:45

Copilot AI reviewed May 11, 2026

View reviewed changes

pethers requested a review from Copilot May 11, 2026 12:55

Copilot started reviewing on behalf of pethers May 11, 2026 12:56 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Copilot started work on behalf of pethers May 11, 2026 13:03 View session

Copilot finished work on behalf of pethers May 11, 2026 13:12

pethers merged commit 1a3cb89 into main May 11, 2026
23 checks passed

pethers deleted the copilot/fix-empty-dashboards branch May 11, 2026 13:25

		const attrsBefore = before.replace(/\bsrc\s=\s"[^"]*"/i, '').trim();
		const attrsAfter = after.replace(/\bsrc\s=\s"[^"]*"/i, '').trim();

Conversation

Copilot AI commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 11, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions Bot commented May 11, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 11, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented May 11, 2026

🔍 Lighthouse Performance Audit

Uh oh!

pethers commented May 11, 2026

Uh oh!

Copilot AI commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 11, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pethers commented May 11, 2026

Uh oh!

Copilot AI commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 11, 2026 •

edited

Loading