Fix broken dashboards: inject theme-toggle/back-to-top/mermaid bootstrap on all 126 dashboard pages by Copilot · Pull Request #2480 · Hack23/riksdagsmonitor

Copilot · 2026-05-14T10:52:48Z

Review new PR comment and identify actionable review thread items.
Inspect current implementations in cypress/support/commands.js and tests/dashboard-pages.test.js.
Apply minimal fixes for attribute assertion semantics and bootstrap quote-style/order assertions.
Run targeted tests for modified files.
Run required validation checks (including CI/workflow investigation and parallel validation).
Reply to the new PR comment with commit hash and evidence.

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/300fe764-350a-430a-86bd-6b81196556ac Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

…ll 126 dashboard pages Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/300fe764-350a-430a-86bd-6b81196556ac Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T10:53:57Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: html-css,javascript,testing,refactor,size-xl

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-05-14T10:54:50Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

This PR fixes a cross-cutting dashboard regression where the static /dashboards/*.html pages were missing the trailing bootstrap that wires up Mermaid initialization, the back-to-top button, and the theme toggle (dark/light mode). It also adds regression tests (unit + Cypress) to prevent silent reintroduction across all dashboard language variants.

Changes:

Updates scripts/build-dashboard-pages.py to extract all trailing scripts up to </body> (instead of only the first <script>).
Adds scripts/patch-dashboard-bootstrap.py to backfill the bootstrap block into already-committed dashboards/*.html pages (idempotently).
Adds structural/unit assertions and Cypress runtime assertions to verify the bootstrap presence and that the theme toggle actually works.

Reviewed changes

Copilot reviewed 131 out of 131 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/build-dashboard-pages.py	Widens `TAIL_SCRIPTS_RE` to capture all tail scripts (including the inject bootstrap) up to `</body>`.
scripts/patch-dashboard-bootstrap.py	New idempotent patcher to insert the inject bootstrap after the dashboard entry script in committed dashboard pages.
dashboards/*.html (126 files)	Adds the inject-IIFE bootstrap block after the main entry script on every dashboard page/language variant.
tests/dashboard-pages.test.js	Adds a per-dashboard-file structural regression guard for the bootstrap block.
cypress/support/commands.js	Adds `cy.expectThemeToggleWorks()` helper to assert runtime theme toggling.
cypress/e2e/dashboards-per-chart/_helpers.js	Wires the theme-toggle runtime assertion into the per-dashboard suite (non-hub dashboards).

+  // DOMContentLoaded. The handler sets `aria-pressed` on the button
+  // during init; use that as the readiness signal.
+  cy.get('#theme-toggle', { timeout: 15000 })
+    .should('have.attr', 'aria-pressed')
+    .and('match', /^(true|false)$/);


+        // The bootstrap must be the documented imperative-inject IIFE
+        // (so Vite's HTML transformer does not try to bundle the
+        // referenced modules). Anchor on the IIFE entry-point and the
+        // three inject() calls in that order.
+        expect(html, `${filename} bootstrap is missing the inject() IIFE wrapper`).toMatch(
+          /function inject\(src,\s*isModule\)/,
+        );


Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/d1ba60ed-2993-466f-8c9c-296043982b98 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T12:05:27Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

github-actions · 2026-05-14T12:14:43Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 132 out of 132 changed files in this pull request and generated 2 comments.

+      it('ships /js/theme-toggle.js + /js/back-to-top.js + /js/lib/mermaid-init.mjs bootstrap', () => {
+        html ||= readPage(filename);
+        expect(html, `${filename} missing /js/theme-toggle.js bootstrap`).toContain("/js/theme-toggle.js");
+        expect(html, `${filename} missing /js/back-to-top.js bootstrap`).toContain("/js/back-to-top.js");
+        expect(html, `${filename} missing /js/lib/mermaid-init.mjs bootstrap`).toContain("/js/lib/mermaid-init.mjs");


+    .should('have.attr', 'aria-pressed')
+    .and('match', /^(true|false)$/);


pethers · 2026-05-14T12:23:19Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/ffa3d9eb-89b5-4d93-8c7d-548fe24530c6 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T12:42:56Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot · 2026-05-14T12:43:00Z

@copilot apply changes based on the comments in this thread

Implemented the review-thread fixes in 28a336d:

corrected the Cypress theme-toggle readiness assertion to validate aria-pressed from the element value (no subject-chain mismatch), and
tightened dashboard-pages bootstrap assertions to be quote-style agnostic and to enforce ordered inject(...) calls.

I also pushed 2b5da54 to clean up unintended generated-file noise so the PR diff remains scoped. Verified with vitest tests/dashboard-pages.test.js and Cypress parties.cy.js (13/13 passing). No UI markup/visual behavior was changed.

github-actions · 2026-05-14T12:44:20Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot AI and others added 2 commits May 14, 2026 10:37

Plan: fix dashboard theme toggle + improve e2e

3e9252f

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/300fe764-350a-430a-86bd-6b81196556ac Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Fix dashboard theme toggle: inject /js/theme-toggle.js bootstrap on a…

77c144a

…ll 126 dashboard pages Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/300fe764-350a-430a-86bd-6b81196556ac Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI assigned Copilot and pethers May 14, 2026

Copilot created this pull request from a session on behalf of pethers May 14, 2026 10:53 View session

github-actions Bot added html-css HTML/CSS changes javascript JavaScript code changes testing Test coverage refactor Code refactoring size-xl Extra large change (> 1000 lines) labels May 14, 2026

Copilot finished work on behalf of pethers May 14, 2026 10:54

Copilot AI requested a review from pethers May 14, 2026 10:54

pethers marked this pull request as ready for review May 14, 2026 10:57

Copilot AI review requested due to automatic review settings May 14, 2026 10:57

Copilot started reviewing on behalf of pethers May 14, 2026 10:57 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Copilot started work on behalf of pethers May 14, 2026 11:38 View session

Harden dashboard tests for deploy-minified HTML

4999f46

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/d1ba60ed-2993-466f-8c9c-296043982b98 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers May 14, 2026 12:05

Merge branch 'main' into copilot/fix-broken-dashboard-pages

2b86c4b

pethers requested a review from Copilot May 14, 2026 12:12

Copilot started reviewing on behalf of pethers May 14, 2026 12:13 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Copilot started work on behalf of pethers May 14, 2026 12:23 View session

Fix dashboard bootstrap assertions and theme-toggle readiness check

28a336d

Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/ffa3d9eb-89b5-4d93-8c7d-548fe24530c6 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Revert unintended generated content changes

2b5da54

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions Bot added documentation Documentation updates translation Translation updates rtl RTL language support (Arabic, Hebrew) news News articles and content generation labels May 14, 2026

Copilot finished work on behalf of pethers May 14, 2026 12:44

pethers requested a review from Copilot May 14, 2026 12:46

Copilot started reviewing on behalf of pethers May 14, 2026 12:47 View session

pethers merged commit 25c751e into main May 14, 2026
18 of 19 checks passed

pethers deleted the copilot/fix-broken-dashboard-pages branch May 14, 2026 12:57

Copilot AI review requested due to automatic review settings May 14, 2026 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken dashboards: inject theme-toggle/back-to-top/mermaid bootstrap on all 126 dashboard pages#2480

Fix broken dashboards: inject theme-toggle/back-to-top/mermaid bootstrap on all 126 dashboard pages#2480
pethers merged 6 commits into
mainfrom
copilot/fix-broken-dashboard-pages

Copilot AI commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

pethers commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		.should('have.attr', 'aria-pressed')
		.and('match', /^(true\|false)$/);

Conversation

Copilot AI commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pethers commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 14, 2026 •

edited

Loading