Harden MCP coverage-state reporting, deferred retries, and voteringar lag diagnostics#2498
Merged
Conversation
Contributor
🏷️ Automatic Labeling SummaryThis PR has been automatically labeled based on the files changed and PR metadata. Applied Labels: size-xs Label Categories
For more information, see |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
7 tasks
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/db0617e3-4e82-40c9-b3ad-61ad861020d0 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
github-actions
Bot
added
documentation
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/db0617e3-4e82-40c9-b3ad-61ad861020d0 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/db0617e3-4e82-40c9-b3ad-61ad861020d0 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/db0617e3-4e82-40c9-b3ad-61ad861020d0 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Copilot
AI
changed the title
[WIP] Improve MCP client to mitigate indexing lag and coverage gaps
Harden MCP coverage-state reporting, deferred retries, and voteringar lag diagnostics
May 15, 2026
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit MCP coverage/provenance reporting to the parliamentary data pipeline so analysis artifacts can distinguish full text, metadata-only responses, not-yet-indexed documents, and empty searches.
Changes:
- Adds MCP coverage/provenance types, client diagnostics wrappers, and coverage inference helpers.
- Introduces a file-backed deferred MCP retry queue and integrates it into the download pipeline/manifest.
- Updates docs and tests for manifest diagnostics, retry queue behavior, smoke testing, and workflow coverage counts.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
tests/network-diagnostics.test.ts |
Updates workflow count/list expectations to 14 news workflows. |
tests/mcp-retry-queue.test.ts |
Adds unit tests for retry queue dedupe and resolved document drain behavior. |
tests/mcp-client-smoke.test.ts |
Adds gated live MCP smoke test for structured provenance. |
tests/mcp-client-core-part2.test.ts |
Adds coverage/diagnostic tests for empty searches, voting lag, and document details. |
tests/data-downloader-enrichment.test.ts |
Updates mock client with MCP base URL for provenance generation. |
tests/auto-full-text-top-n.test.ts |
Updates mocks and adds manifest serialization assertions for coverage/queue sections. |
scripts/types/mcp.ts |
Defines coverage state, provenance, signal, and diagnostic interfaces. |
scripts/parliamentary-data/mcp-retry-queue.ts |
Adds file-backed retry queue creation, persistence, enqueue, and drain logic. |
scripts/parliamentary-data/full-text-threshold.ts |
Extracts shared full-text length threshold. |
scripts/parliamentary-data/data-downloader.ts |
Propagates MCP coverage/provenance through downloads and full-text enrichment. |
scripts/mcp-client/index.ts |
Exposes new diagnostic wrapper convenience functions. |
scripts/mcp-client/coverage.ts |
Adds coverage inference and provenance helper utilities. |
scripts/mcp-client/client.ts |
Adds diagnostic wrappers for document search, voting search, and document details. |
scripts/mcp-client.ts |
Re-exports the new MCP diagnostic APIs. |
scripts/download-parliamentary-data.ts |
Integrates retry draining/enqueueing and extends manifest serialization. |
scripts/data-transformers/types.ts |
Adds MCP coverage/provenance fields to raw document shape. |
data/mcp-retry-queue.json |
Adds initial empty retry queue file. |
analysis/templates/data-download-manifest.md |
Documents the new MCP coverage-state manifest contract. |
analysis/methodologies/ai-driven-analysis-guide.md |
Updates analysis workflow guidance for coverage/provenance and deferred retries. |
Comment on lines
+893
to
+906
| const provenance = buildMcpProvenance({ | ||
| endpoint: client.baseURL, | ||
| tool: 'get_dokument_innehall', | ||
| query: { dok_id: dokId, include_full_text: true }, | ||
| resultCount: 0, | ||
| coverageState: 'not_indexed', | ||
| }); | ||
| outcome = { | ||
| dokId, | ||
| success: false, | ||
| chars: 0, | ||
| reason: `fetchDocumentDetails failed: ${err instanceof Error ? err.message : String(err)}`, | ||
| coverageState: 'not_indexed', | ||
| provenance, |
| dokId, | ||
| true, | ||
| { | ||
| requestedDate: typeof docRecord['datum'] === 'string' ? docRecord['datum'] as string : null, |
| try { | ||
| const response = await this.fetchDocumentDetails(dok_id, include_full_text); | ||
| const coverageState = inferDocumentCoverageState(response, { | ||
| requestedDate: options.requestedDate ?? extractDocumentDate(response), |
Comment on lines
+183
to
+257
| if (entry.resourceType === 'document_fulltext') { | ||
| const result = await client.fetchDocumentDetailsWithCoverage( | ||
| entry.resourceId, | ||
| true, | ||
| { | ||
| requestedDate: (entry.params['requestedDate'] as string | undefined) ?? null, | ||
| retrieval: 'retry_queue', | ||
| }, | ||
| ); | ||
|
|
||
| diagnostics.push({ | ||
| tool: entry.tool, | ||
| query: { ...entry.params, dok_id: entry.resourceId, include_full_text: true }, | ||
| resultCount: result.resultCount, | ||
| coverageState: result.coverageState, | ||
| provenance: result.provenance, | ||
| notes: entry.reason, | ||
| }); | ||
|
|
||
| if (result.coverageState === 'full_text') { | ||
| resolved++; | ||
| resolvedDocuments[entry.resourceId] = result.document; | ||
| continue; | ||
| } | ||
|
|
||
| remaining.push({ | ||
| ...entry, | ||
| attemptCount: entry.attemptCount + 1, | ||
| coverageState: result.coverageState, | ||
| reason: entry.reason ?? `Deferred ${entry.tool} retry still ${result.coverageState}`, | ||
| lastAttemptAt, | ||
| }); | ||
| retained++; | ||
| continue; | ||
| } | ||
|
|
||
| const votingParams = entry.params; | ||
| if (typeof votingParams !== 'object' || votingParams === null) { | ||
| remaining.push({ | ||
| ...entry, | ||
| attemptCount: entry.attemptCount + 1, | ||
| reason: 'retry queue entry has invalid voting params payload', | ||
| lastAttemptAt, | ||
| }); | ||
| retained++; | ||
| continue; | ||
| } | ||
|
|
||
| const votingResult = await client.fetchVotingRecordsWithDiagnostics( | ||
| votingParams as FetchVotingFilters, | ||
| ); | ||
|
|
||
| diagnostics.push({ | ||
| tool: entry.tool, | ||
| query: { ...(entry.params as Record<string, unknown>) }, | ||
| resultCount: votingResult.resultCount, | ||
| coverageState: votingResult.coverageState, | ||
| provenance: votingResult.provenance, | ||
| notes: entry.reason, | ||
| ...(votingResult.signal ? { signal: votingResult.signal } : {}), | ||
| }); | ||
|
|
||
| if (votingResult.resultCount > 0) { | ||
| resolved++; | ||
| continue; | ||
| } | ||
|
|
||
| remaining.push({ | ||
| ...entry, | ||
| attemptCount: entry.attemptCount + 1, | ||
| coverageState: votingResult.coverageState, | ||
| reason: votingResult.signal?.message ?? entry.reason, | ||
| lastAttemptAt, | ||
| }); | ||
| retained++; |
Comment on lines
+231
to
+233
| const votingResult = await client.fetchVotingRecordsWithDiagnostics( | ||
| votingParams as FetchVotingFilters, | ||
| ); |
| const coverageState = inferDocumentCoverageState( | ||
| { ...docRecord, ...details }, | ||
| { | ||
| requestedDate: typeof docRecord['datum'] === 'string' ? docRecord['datum'] as string : null, |
Comment on lines
+397
to
+408
| const notes = outcome?.reason | ||
| ?? outcome?.filePath | ||
| ?? (doc.contentFetched | ||
| ? (typeof doc.summary === 'string' && doc.summary.trim().length > 0 ? 'summary present' : 'metadata-only payload') | ||
| : 'list payload only; get_dokument_innehall not attempted in this run'); | ||
| return { | ||
| dokId, | ||
| coverageState: provenance.coverageState, | ||
| retrieval: provenance.retrieval, | ||
| tool: provenance.tool, | ||
| resultCount: provenance.resultCount, | ||
| notes, |
Comment on lines
+537
to
+547
| toolDiagnostics.push({ | ||
| tool: task.source, | ||
| query, | ||
| resultCount: 0, | ||
| coverageState: 'search_empty', | ||
| provenance: buildMcpProvenance({ | ||
| endpoint: client.baseURL, | ||
| tool: task.source, | ||
| query, | ||
| resultCount: 0, | ||
| coverageState: 'search_empty', |
Comment on lines
+637
to
+643
| const resolvedIds = new Set(Object.keys(retryDrain.resolvedDocuments)); | ||
| for (const doc of allDocs) { | ||
| const dokId = extractDokId(doc, ''); | ||
| if (!dokId || !resolvedIds.has(dokId)) continue; | ||
| Object.assign(doc, retryDrain.resolvedDocuments[dokId]); | ||
| } | ||
| console.log(` 🔁 Deferred queue restored full text for ${resolvedIds.size} document(s)`); |
Member
|
@copilot apply changes based on the comments in this thread |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
| resultCount, | ||
| coverageState, | ||
| }); | ||
| Object.assign(record, attachCoverageMetadata(record, provenance)); |
Comment on lines
+722
to
+739
| if (fullTextOutcomes) { | ||
| const docMap = new Map(allDocs.map(doc => [extractDokId(doc, ''), doc])); | ||
| for (const outcome of fullTextOutcomes) { | ||
| const doc = docMap.get(outcome.dokId); | ||
| if (!doc) continue; | ||
| if (outcome.coverageState !== 'full_text' && typeof doc.datum === 'string' && doc.datum.slice(0, 10) === date) { | ||
| queueEntries.push(createRetryQueueEntry({ | ||
| resourceType: 'document_fulltext', | ||
| resourceId: outcome.dokId, | ||
| tool: 'get_dokument_innehall', | ||
| coverageState: outcome.coverageState, | ||
| docType, | ||
| params: { requestedDate: doc.datum.slice(0, 10), include_full_text: true }, | ||
| reason: outcome.reason, | ||
| requestedAt: new Date().toISOString(), | ||
| })); | ||
| } | ||
| } |
| const record = doc as Record<string, unknown>; | ||
| if (!record['mcpCoverageState']) { | ||
| const coverageState = inferDocumentCoverageState(record, { | ||
| requestedDate: typeof doc.datum === 'string' ? doc.datum : null, |
Comment on lines
821
to
+829
| let content = selectContent(docRecord); | ||
| const runDate = new Date().toISOString().slice(0, 10); | ||
|
|
||
| if (content.length <= FULL_TEXT_MIN_LENGTH) { | ||
| details = (await client.fetchDocumentDetails(dokId, true)) as Record<string, unknown>; | ||
| const detailsWithCoverage = await client.fetchDocumentDetailsWithCoverage( | ||
| dokId, | ||
| true, | ||
| { | ||
| requestedDate: runDate, |
Comment on lines
+217
to
+229
| } catch (drainErr) { | ||
| console.warn( | ||
| `[mcp-retry-queue] Document retry failed for ${entry.resourceId}:`, | ||
| drainErr instanceof Error ? drainErr.message : String(drainErr), | ||
| ); | ||
| remaining.push({ | ||
| ...entry, | ||
| attemptCount: entry.attemptCount + 1, | ||
| reason: `Retry failed: ${drainErr instanceof Error ? drainErr.message : String(drainErr)}`, | ||
| lastAttemptAt, | ||
| }); | ||
| retained++; | ||
| } |
Comment on lines
+299
to
+304
| const notes = diag.signal?.code | ||
| ? `${diag.signal.code}: ${diag.signal.message}` | ||
| : (diag.notes ?? ''); | ||
| lines.push( | ||
| `| ${diag.tool} | \`${JSON.stringify(diag.query)}\` | ${diag.resultCount} | ${diag.coverageState} | ${notes} |`, | ||
| ); |
Comment on lines
+211
to
+217
| const NOT_INDEXED_ERROR_PATTERNS = [ | ||
| 'not found', | ||
| '404', | ||
| 'not indexed', | ||
| 'no document', | ||
| 'ingen', | ||
| ] as const; |
Comment on lines
+897
to
+901
| // Distinguish true indexing-gap errors from transient/operational failures | ||
| const isNotIndexed = ['not found', '404', 'not indexed', 'no document', 'ingen'].some( | ||
| (p) => msgLower.includes(p), | ||
| ); | ||
| const state = isNotIndexed ? 'not_indexed' : 'fetch_error' as const; |
Comment on lines
+288
to
+293
| const updatedQueue: MCPRetryQueueFile = { | ||
| schema: MCP_RETRY_QUEUE_SCHEMA, | ||
| updatedAt: now.toISOString(), | ||
| entries: remaining, | ||
| }; | ||
| saveMcpRetryQueue(updatedQueue, queuePath); |
Comment on lines
+260
to
+262
| if (votingResult.resultCount > 0) { | ||
| resolved++; | ||
| continue; |
Member
|
@copilot apply changes based on the comments in this thread and resolve conflicts and improve |
…etry-queue isolation, escaping) Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/70723dd0-25d0-4003-80e3-19b0590ab06f Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Merged
Test runs after the merge: targeted ( |
github-actions
Bot
added
html-css
Member
|
@copilot resolve the merge conflicts in this pull request |
…indexing-lag # Conflicts: # scripts/download-parliamentary-data.ts # tests/auto-full-text-top-n.test.ts Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Resolved in |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+284
to
+288
| return str | ||
| .replace(/\r\n?/g, ' ') | ||
| .replace(/\n/g, ' ') | ||
| .replace(/\t/g, ' ') | ||
| .replace(/\|/g, '\\|') |
Comment on lines
+875
to
+887
| const detailsWithCoverage = await client.fetchDocumentDetailsWithCoverage( | ||
| dokId, | ||
| true, | ||
| { | ||
| requestedDate: runDate, | ||
| }, | ||
| ); | ||
| details = detailsWithCoverage.document; | ||
| content = selectContent(details); | ||
| } | ||
|
|
||
| const coverageState = inferDocumentCoverageState( | ||
| { ...docRecord, ...(details ?? {}) }, |
Comment on lines
+672
to
+679
| const coverageState = inferDocumentCoverageState( | ||
| { ...docRecord, ...details }, | ||
| { | ||
| requestedDate: analysisRunDate, | ||
| fullTextRequested: true, | ||
| }, | ||
| ); | ||
| docRecord['mcpCoverageState'] = coverageState; |
Comment on lines
+713
to
+721
| let mergedVoteCount = 0; | ||
| for (const [queryKey, items] of Object.entries(retryDrain.resolvedVoteringar)) { | ||
| if (!Array.isArray(items) || items.length === 0) continue; | ||
| data.votes.push(...(items as RawDocument[])); | ||
| mergedVoteCount += items.length; | ||
| console.log(` 🗳️ Recovered ${items.length} voteringar from deferred queue (${queryKey})`); | ||
| } | ||
| if (mergedVoteCount > 0) { | ||
| console.log(` 🔁 Deferred queue restored ${mergedVoteCount} voteringar row(s) — appended to current-run output`); |
Comment on lines
+296
to
+298
| // the current download selection. | ||
| if (Array.isArray(votingResult.items)) { | ||
| resolvedVoteringar[entry.resourceId] = votingResult.items as unknown[]; |
Member
|
@copilot apply changes based on the comments in this thread |
Copilot stopped work on behalf of
pethers due to an error
May 15, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan — round 2 review feedback
origin/mainand resolve conflicts indownload-parliamentary-data.ts+auto-full-text-top-n.test.tsmcpCoverageState/mcpProvenance/mcpSignalsintoanalysis/data/raw files viastripInMemoryCoverageMetadataindata-persistence.tsanalysisRunDateplumb-through so the default enrichment path's coverage state is tied to the pipeline date (and anynot_indexedenriched docs are still surfaced to the retry queue)buildDocumentCoverageSummarynow takesanalysisRunDatefrom the pipeline (date) rather than the host wall clockfetchFullTextForTopNaccepts{ runDate }and threads it intoinferDocumentCoverageStatefetch_errordiagnostic with the exact query + error so they appear in## MCP Query DiagnosticsescapeMarkdownCellescapes pipes / collapses newlines / tabs across the diagnostics, coverage and full-text tables404/not foundmatching withisDocumentNotIndexedError— transport sentinels (mcp server error,econnrefused,5xx, …) forcefetch_error; document-level not-found requires a dok_id echodrainMcpRetryQueueonly writes the queue file when there was real work (entries pre-existing, processed, expired, or remaining)resolvedVoteringarand the downloader appends recovered rows todata.votesfor the current runtests/mcp-retry-queue.test.ts,tests/auto-full-text-top-n.test.ts,tests/data-persistence.test.ts) — 87 tests passingorigin/main, kept our coverage/provenance features in both conflict zones