Use hreflangCode() helper in tests instead of inline 'no'→'nb' mapping#832
Merged
pethers merged 2 commits intomain-7a9239b964b147d1from Mar 5, 2026
Merged
Use hreflangCode() helper in tests instead of inline 'no'→'nb' mapping#832pethers merged 2 commits intomain-7a9239b964b147d1from
pethers merged 2 commits intomain-7a9239b964b147d1from
Conversation
Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add opposition motions analysis for 5 March 2026
Use hreflangCode() helper in tests instead of inline 'no'→'nb' mapping
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests in
news-generation-e2e.test.tsduplicated the Norwegian BCP-47 mapping inline (lang === 'no' ? 'nb' : lang) instead of using the sharedhreflangCode()helper that production code already relies on.Changes
tests/pipeline/news-generation-e2e.test.tshreflangCodefromscripts/article-template/helpers.jshreflangCode(lang)in thelangattribute,inLanguageJSON-LD, and hreflang tag consistency testsAny future addition to
hreflangCode()(e.g. a new language alias) now propagates to the tests automatically.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.