Skip to content

Fix ESLint CI failure and accessibility/SEO issues in evening analysis articles#838

Merged
pethers merged 2 commits intoevening-analysis-2026-03-05-13bbbf9821635a4dfrom
copilot/sub-pr-836
Mar 5, 2026
Merged

Fix ESLint CI failure and accessibility/SEO issues in evening analysis articles#838
pethers merged 2 commits intoevening-analysis-2026-03-05-13bbbf9821635a4dfrom
copilot/sub-pr-836

Conversation

Copy link
Contributor

Copilot AI commented Mar 5, 2026

ESLint was failing with no-empty errors in the newly added js/theme-init.js, and several review comments flagged accessibility and SEO inconsistencies in the localized news articles.

Changes

ESLint fix (js/theme-init.js, js/theme-toggle.js)

Empty catch blocks caused hard errors; caught error variable naming violated the caughtErrorsIgnorePattern: '^_' rule:

// Before
try { t = localStorage.getItem(key); } catch (e) {}

// After
try { t = localStorage.getItem(key); } catch (_e) { /* ignore storage errors */ }

Same _e rename applied to theme-toggle.js to suppress warnings consistently.

Spanish <h1> alignment (2026-03-05-evening-analysis-es.html)

<h1> was missing the "Análisis vespertino: " prefix and started lowercase, diverging from <title>, OG, and JSON-LD headline — fixed to match all metadata.

Korean page language annotation (2026-03-05-evening-analysis-ko.html)

English-language paragraphs and headings embedded in the lang="ko" document lacked lang="en" — screen readers would have applied Korean pronunciation to English text. Added lang="en" to all English-content elements in the article body.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…English passages

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix evening analysis report update for March 2026 Fix ESLint CI failure and accessibility/SEO issues in evening analysis articles Mar 5, 2026
@pethers pethers marked this pull request as ready for review March 5, 2026 21:25
@pethers pethers merged commit 38f3b5f into evening-analysis-2026-03-05-13bbbf9821635a4d Mar 5, 2026
@pethers pethers deleted the copilot/sub-pr-836 branch March 5, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants