Fix ESLint CI failure and accessibility/SEO issues in evening analysis articles#838
Merged
pethers merged 2 commits intoevening-analysis-2026-03-05-13bbbf9821635a4dfrom Mar 5, 2026
Merged
Conversation
7 tasks
…English passages Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix evening analysis report update for March 2026
Fix ESLint CI failure and accessibility/SEO issues in evening analysis articles
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint was failing with
no-emptyerrors in the newly addedjs/theme-init.js, and several review comments flagged accessibility and SEO inconsistencies in the localized news articles.Changes
ESLint fix (
js/theme-init.js,js/theme-toggle.js)Empty catch blocks caused hard errors; caught error variable naming violated the
caughtErrorsIgnorePattern: '^_'rule:Same
_erename applied totheme-toggle.jsto suppress warnings consistently.Spanish
<h1>alignment (2026-03-05-evening-analysis-es.html)<h1>was missing the"Análisis vespertino: "prefix and started lowercase, diverging from<title>, OG, and JSON-LD headline — fixed to match all metadata.Korean page language annotation (
2026-03-05-evening-analysis-ko.html)English-language paragraphs and headings embedded in the
lang="ko"document lackedlang="en"— screen readers would have applied Korean pronunciation to English text. Addedlang="en"to all English-content elements in the article body.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.