fix: missing team report system by hadiafifah · Pull Request #492 · HackDavis/hackdavis-hub

hadiafifah · 2026-04-16T06:30:22Z

Summary

This PR adds an admin recovery flow for missing teams: admins can now mark a team as present and restore it back to relevant judges’ queues.

What Changed

Backend

Added restoreMissingTeam(team_id) in the teams missing-report action module.
Enforced admin-only access inside the action (auth() + role check).
Restore logic now:
- Collects unique judge IDs from team.reports.
- For each reporting judge, requeues the team to the end only if: the submission exists for that judge/team, and is_scored === false.
- Skips scored submissions (existing judged work is preserved).
- Sets team.active = true.
- Clears team.reports after successful processing.

Admin UI (/admin/teams)

Added a team-level action button and helper text on reported teams
Added confirmation prompt before execution

Behavior Notes

Only judges who reported the team missing and still have an unscored submission are requeued.
Non-reporting judges are unaffected.
Scored submissions are not modified.

Fixes #466

ReehalS

Looked this over, changes look good, @hadiafifah I assume you've tested this already, if you want me to do the full flow testing as well lmk.

ReehalS

Add Tests to verify this functionality actually works. (including for code you didn't write for the missing teams functionality), the person who initially wrote this likely fully vibecoded it

ReehalS · 2026-04-24T00:17:50Z

When teams are to be marked present, also mark the team's active=true regardless of what it was before, and move that team back into all of the judges whose queues that team has been marked missing with.

ReehalS

LGTM!

Copilot

Pull request overview

Adds an admin-only recovery flow for “missing team” reports so admins can mark a reported team as present, re-queue it for only the reporting judges who still have an unscored submission, and clear the missing reports.

Changes:

Added restoreMissingTeam(team_id) server action with admin authorization, selective re-queuing, and report clearing.
Updated Admin Teams UI to surface a “Mark Team as Present” action on reported teams with confirmation + loading state.
Added Jest tests covering reportMissingProject and the new restoreMissingTeam behavior.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
package-lock.json	Lockfile updates (peer metadata changes).
app/(pages)/admin/teams/page.tsx	Wires the new restore action into the admin teams page, including confirmation and refresh.
app/(pages)/admin/_components/Teams/TeamCard.tsx	Adds a per-team “Mark Team as Present” button and disables it while restoring.
app/(pages)/admin/_components/Teams/TeamCard.module.scss	Styles for the new restore button and helper text.
app/(api)/_actions/teams/reportMissingTeam.ts	Implements `restoreMissingTeam` server action: admin-gated, dedupes reporting judges, requeues unscored submissions, clears reports, reactivates team.
tests/actions/reportMissingTeam.test.ts	New unit tests for missing-report and restore flows using mocked datalib/auth.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+      const reorderResList = await Promise.all(
+        reorderedSubmissions.map((sub: Submission) =>
+          UpdateSubmission(sub.judge_id, sub.team_id, {
+            $set: { queuePosition: sub.queuePosition },
+          })
+        )
+      );
+
+      if (!reorderResList.every((res: any) => res.ok)) {
+        throw new Error(
+          `Not all submission order updates succeeded\n${JSON.stringify(
+            reorderResList
+          )}`
+        );
+      }


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

michelleyeoh · 2026-05-01T18:38:02Z

Note: Accidentally asked copolit for fix, but I undid the commit

hadiafifah added 2 commits April 15, 2026 23:15

added admin only missing team restore logic and button

b3d8191

changed button typography and added safety guard

ac46caf

hadiafifah temporarily deployed to development April 16, 2026 06:30 — with GitHub Actions Inactive

added comments and changed function name for readability

5e24ef0

hadiafifah temporarily deployed to development April 16, 2026 06:34 — with GitHub Actions Inactive

Merge branch 'main' into fix/missing-team-report

ca212c8

hadiafifah temporarily deployed to development April 16, 2026 23:51 — with GitHub Actions Inactive

hadiafifah requested a review from ReehalS April 17, 2026 00:28

ReehalS approved these changes Apr 23, 2026

View reviewed changes

Merge branch 'main' into fix/missing-team-report

c969fc4

ReehalS temporarily deployed to development April 23, 2026 22:50 — with GitHub Actions Inactive

ReehalS requested changes Apr 23, 2026

View reviewed changes

added functionality to button to set active true

4954138

hadiafifah temporarily deployed to development April 24, 2026 00:26 — with GitHub Actions Inactive

Merge branch 'main' into fix/missing-team-report

33499d1

hadiafifah temporarily deployed to development April 29, 2026 06:19 — with GitHub Actions Inactive

changed active behavior and added tests

e12c357

hadiafifah temporarily deployed to development April 29, 2026 20:06 — with GitHub Actions Inactive

Merge branch 'main' into fix/missing-team-report

e308873

ReehalS temporarily deployed to development May 1, 2026 06:02 — with GitHub Actions Inactive

ReehalS previously approved these changes May 1, 2026

View reviewed changes

michelleyeoh requested a review from Copilot May 1, 2026 17:42

Copilot started reviewing on behalf of michelleyeoh May 1, 2026 17:43 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Add generic error message

dac8279

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

michelleyeoh dismissed ReehalS’s stale review via dac8279 May 1, 2026 18:26

michelleyeoh had a problem deploying to development May 1, 2026 18:26 — with GitHub Actions Failure

Copilot started work on behalf of michelleyeoh May 1, 2026 18:27 View session

lint and error message fix

d910011

michelleyeoh temporarily deployed to development May 1, 2026 18:30 — with GitHub Actions Inactive

Copilot finished work on behalf of michelleyeoh May 1, 2026 18:32

Copilot AI requested a review from michelleyeoh May 1, 2026 18:32

michelleyeoh force-pushed the fix/missing-team-report branch from b79fd91 to d910011 Compare May 1, 2026 18:36

michelleyeoh temporarily deployed to development May 1, 2026 18:36 — with GitHub Actions Inactive

HackDavis deleted a comment from Copilot AI May 1, 2026

michelleyeoh approved these changes May 1, 2026

View reviewed changes

michelleyeoh merged commit 087904e into main May 1, 2026
3 checks passed

michelleyeoh deleted the fix/missing-team-report branch May 1, 2026 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing team report system#492

fix: missing team report system#492
michelleyeoh merged 11 commits intomainfrom
fix/missing-team-report

hadiafifah commented Apr 16, 2026 •

edited

Loading

Uh oh!

ReehalS left a comment

Uh oh!

ReehalS left a comment •

edited

Loading

Uh oh!

ReehalS commented Apr 24, 2026

Uh oh!

ReehalS left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

michelleyeoh commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

hadiafifah commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Backend

Admin UI (/admin/teams)

Behavior Notes

Uh oh!

ReehalS left a comment

Choose a reason for hiding this comment

Uh oh!

ReehalS left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReehalS commented Apr 24, 2026

Uh oh!

ReehalS left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

michelleyeoh commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hadiafifah commented Apr 16, 2026 •

edited

Loading

ReehalS left a comment •

edited

Loading