Fix/hero title removing tailwind #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going forward, I'd like to phase out Tailwind usage. For explanations why, please refer to the following which can explain better than I ever will: https://gomakethings.com/tailwind-is-bad/ https://www.aleksandrhovhannisyan.com/blog/why-i-dont-like-tailwind-css/ I'm discussing this change with incoming/remaining members of the website team. This particular commit should be unnoticable and non-breaking.
A slight transparency fade prevents descenders from interfering with the foreground text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Tailwind from the HeroTitle widget, and also allows for descenders in titles that won't affect any foreground text.
I haven't done extensive testing on mobile accessibility.