homework from Ann-Grabetski #155

Ann-Grabetski · 2019-08-16T05:49:33Z

Review

yash-kapila

Hi @Ann-Grabetski - I've finished reviewing your homework. Most of it looks fine but I have a few comments which would be good for you to implement. Also, for week3, I couldn't find submissions for questions 12-17 here https://github.com/HackYourFuture/JavaScript1/blob/master/Week3/MAKEME.md. Could you please have a look? Please drop a message on Slack if you have any questions. Have a good weekend and make sure you use this free week for revising all topics learnt so far. 🙂

yash-kapila · 2019-08-23T19:09:22Z

Week2/arraysTask-1.js

+const reverseArray = splitString.reverse();
+console.log('reverse array: '+reverseArray);
+const joinArray = reverseArray.join('');
+console.log('corrected string is: '+joinArray);


Very well. The logic is correct but you can also reduce it in a single statement using a programming practice called method chaining. For example,

const str = 'dlroW olleH'; const reversedString = str.split('').reverse().join('');

Here I have merged all three operations in a single statement using method chaining.

Oh! It's a very great way! Thank you to show me.

yash-kapila · 2019-08-23T19:11:07Z

Week2/homework/arraysTask-1.js

+const reverseArray = splitString.reverse();
+console.log('reverse array: '+reverseArray);
+const joinArray = reverseArray.join('');
+console.log('corrected string is: '+joinArray);


Wondering why did you have to repeat this homework submission here? I remember that you were unable to make it to the Week1 where we covered Gitflow in a bit more detail. Let me or Tjebbe know please if you have any confusions or questions around working with Git and we can perhaps work on something. 🙂

Yes, I did it accidentally then I figured out how to correctly use all this git system.

yash-kapila · 2019-08-23T19:18:30Z

Week2/homework/stringsTask-1.js

+const myString = "hello,this,is,a,difficult,to,read,sentence";
+console.log('my string is: '+myString);
+console.log('length of the string is: '+myString.length+' characters');
+console.log('corrected string is: '+myString.replace(/,/g,' '));


👍 for logic. I would also like to introduce a new feature in JavaScript ES6 called template literals. It can be found here - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Using template literals allows you to combine variables and strings and avoid using + operator to concatenate strings.

`corrected string is: ${myString.replace(/,/g, ' '});`

I already start to use them. And I love it!

yash-kapila · 2019-08-23T19:18:57Z

Week2/homework/stringsTask-2.js

+const reverseArray = splitString.reverse();
+console.log('reverse array: '+reverseArray);
+const joinArray = reverseArray.join('');
+console.log('corrected string is: '+joinArray);


This again? 🤔

yash-kapila · 2019-08-23T19:20:55Z

Week2/homework/task01HelloWorld.js

+    console.log ( greetings + ' // ' + language)
+    };
+  helloWorld ('Halo, dunia!', 'Indonesian');
+  helloWorld ('Ciao, mondo!', 'Italian');


Very nice of you to create a function for this purpose. 👏

However, there is a slight indentation problem on line 3. 🙂

yash-kapila · 2019-08-23T20:02:03Z

Week3/task05ObjectProperties.js

+    console.log('The actual values of the parameters is:');
+    let x;
+    for (x in person) {
+    console.log(person[x]);


Hmm.. I think a better way to do this would be like this:

function showPropValue(obj) { for (const prop in obj) { console.log(obj[prop]); } } showPropValue(person);

What do you think? Can you see some advantages of writing a function like this?

Well, I think I wrote pretty the same function. The only difference is that my function shows not only values but names of properties also. As it was asked in a task.

yash-kapila · 2019-08-23T20:04:06Z

Week3/task06VehicleBeginning.js

+        console.log('a '+color+' motorbike');
+    };
+};
+vehicleType("blue",2);


yash-kapila · 2019-08-23T20:04:15Z

Week3/task07SingleLine.js

@@ -0,0 +1 @@
+console.log( 3 === 3 ? 'yes' : 'no');


yash-kapila · 2019-08-23T20:07:15Z

Week3/task08Vehicles.js

+function vehicle(color, code, age) {
+    const valueOfColor = color;
+    const valueOfCode = vehicleCodes[code];
+    const valueOfAge = age <= 1 ? 'new' : 'used';


Good use of conditional operator here 👍

yash-kapila · 2019-08-23T20:08:31Z

Week3/task08Vehicles.js

+    let arr1 = vehicleCodes.slice(0, [vehicleCodes.length-1]);
+    let str1 = arr1.toString();
+    let str2 = str1.replace(/,/g,', ');
+    console.log("Amazing Joe's Garage, we service "+str2+' and '+strLast+'.');


Hmm.. I think this isn't complete. The requirement was to have the output like "Amazing Joe's Garage, we service cars, motorbikes, caravans and bikes." with plurals instead of singular values. Could you please have a look again?

Yes, it wasn't completed. I finished and applied it now.

…Grabetski

Ann-Grabetski · 2019-09-03T16:31:53Z

Hi @Ann-Grabetski - I've finished reviewing your homework. Most of it looks fine but I have a few comments which would be good for you to implement. Also, for week3, I couldn't find submissions for questions 12-17 here https://github.com/HackYourFuture/JavaScript1/blob/master/Week3/MAKEME.md. Could you please have a look? Please drop a message on Slack if you have any questions. Have a good weekend and make sure you use this free week for revising all topics learnt so far. 🙂
Hi @yash-kapila !
Yes, I didn't finish all of the tasks then. Now I added the missing, and also made implements according to your comments. Please make a re-review. Thank you for your time!

Ann-Grabetski

Hi @yash-kapila !
Yes, I didn't finish all of the tasks then. Now I added the missing, and also made implements according to your comments. Please make a re-review. Thank you for your time!

Ann-Grabetski · 2019-09-03T16:37:06Z

Week2/arraysTask-1.js

+const reverseArray = splitString.reverse();
+console.log('reverse array: '+reverseArray);
+const joinArray = reverseArray.join('');
+console.log('corrected string is: '+joinArray);


Oh! It's a very great way! Thank you to show me.

Ann-Grabetski · 2019-09-03T16:39:52Z

Week2/homework/arraysTask-1.js

+const reverseArray = splitString.reverse();
+console.log('reverse array: '+reverseArray);
+const joinArray = reverseArray.join('');
+console.log('corrected string is: '+joinArray);


Yes, I did it accidentally then I figured out how to correctly use all this git system.

Ann-Grabetski · 2019-09-03T16:40:46Z

Week2/homework/stringsTask-1.js

+const myString = "hello,this,is,a,difficult,to,read,sentence";
+console.log('my string is: '+myString);
+console.log('length of the string is: '+myString.length+' characters');
+console.log('corrected string is: '+myString.replace(/,/g,' '));


I already start to use them. And I love it!

Ann-Grabetski · 2019-09-03T16:42:53Z

Week2/homework/task01HelloWorld.js

+    console.log ( greetings + ' // ' + language)
+    };
+  helloWorld ('Halo, dunia!', 'Indonesian');
+  helloWorld ('Ciao, mondo!', 'Italian');


Ann-Grabetski · 2019-09-03T16:44:23Z

Week2/homework/task03IntegerVariable.js

+let x;
+console.log("the value of my variable x will be: 13");
+console.log(x);
+x=13;


Ann-Grabetski · 2019-09-03T16:58:30Z

Week3/task02Arrays.js

+console.log("I think this line is very strange. I don't know why am I writing it :(");
+console.log('The array has a length of: '+favoriteAnimals.length);
+function deleteGiraffe() {
+    let giraffe = favoriteAnimals.indexOf("giraffe");


Ann-Grabetski · 2019-09-03T17:00:25Z

Week3/task03SumOfArguments.js

+    x = a + b + c;
+    return x;
+};
+abcSum(1,2,3);


Now I understand. Thank you.

Ann-Grabetski · 2019-09-03T17:01:01Z

Week3/task05ObjectProperties.js

@@ -0,0 +1,14 @@
+let person = {


Ann-Grabetski · 2019-09-03T17:39:06Z

Week3/task05ObjectProperties.js

+    console.log('The actual values of the parameters is:');
+    let x;
+    for (x in person) {
+    console.log(person[x]);


Well, I think I wrote pretty the same function. The only difference is that my function shows not only values but names of properties also. As it was asked in a task.

Ann-Grabetski · 2019-09-03T17:41:28Z

Week3/task08Vehicles.js

+    let arr1 = vehicleCodes.slice(0, [vehicleCodes.length-1]);
+    let str1 = arr1.toString();
+    let str2 = str1.replace(/,/g,', ');
+    console.log("Amazing Joe's Garage, we service "+str2+' and '+strLast+'.');


Yes, it wasn't completed. I finished and applied it now.

anngrrr added 3 commits August 16, 2019 07:38

homework from Ann-Grabetski

5d9d7df

homework from Ann-Grabetski

5b61855

homework from Ann-Grabetski

a44a4f2

NoerGitKat added homework3 to review labels Aug 18, 2019

yash-kapila self-assigned this Aug 22, 2019

yash-kapila added review in progress and removed to review labels Aug 22, 2019

yash-kapila suggested changes Aug 23, 2019

View reviewed changes

yash-kapila added needs work reviewed and removed review in progress labels Aug 23, 2019

anngrrr added 2 commits September 1, 2019 10:34

Additional part of JavaScript1 Week3 HomeWork from Ann-Grabetski

5a57336

the final part of implementation JavaScript1 Week3 HomeWork from Ann-…

9522342

…Grabetski

Ann-Grabetski commented Sep 3, 2019

View reviewed changes

yash-kapila approved these changes Sep 3, 2019

View reviewed changes

yash-kapila removed the needs work label Sep 3, 2019

yash-kapila closed this Sep 3, 2019

		@@ -0,0 +1 @@
		console.log( 3 === 3 ? 'yes' : 'no'); No newline at end of file

homework from Ann-Grabetski #155

homework from Ann-Grabetski #155

Uh oh!

Conversation

Ann-Grabetski commented Aug 16, 2019

Uh oh!

yash-kapila left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ann-Grabetski commented Sep 3, 2019

Uh oh!

Ann-Grabetski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants