-
Notifications
You must be signed in to change notification settings - Fork 327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the instructions again carefully and try to implement what was asked.
Don't let my request for changes discourage you, you clearly understand how to program, and are doing great!
Week1/homework/app.js
Outdated
| let list = document.createElement('ul'); | ||
| divElement.appendChild(list); | ||
| let line = document.createElement('li'); | ||
| line.innerText = 'harry_potter_chamber_secrets'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the instructions again carefully. The idea is that you put all the data about books in the bookDetails object and that you loop over the bookTitles array to get the data from this object.
You have now put the data (like the title) in function instead of taking it from the object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this code. Created new for loop inside of the function. But there is not any bookDetails object yet. I picked bookTitles's child.
//1.3
Thank you for your feedback
| const bookInfo = Object.entries(bookDetails); | ||
| console.log(bookInfo); | ||
|
|
||
| for (let i = 0; i < bookInfo.length; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you should loop over the bookTitles and use each value to access the data about each book in the bookDetails object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this code and use bookInfo.
const bookInfo = Object.entries(bookDetails);
//1.8
Thank you for your feedback.
|
@ahmthsrvsmz , are you done implementing the feedback from @wilgert ? If so, ask him to check it :) |
No description provided.