This repository was archived by the owner on May 14, 2024. It is now read-only.
NesibeInce JS2HW1 #469
Closed
NesibeInce JS2HW1 #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilgert
suggested changes
Sep 4, 2019
Week1/homework/app.js
Outdated
| // } | ||
| // getBooks(bookTitles); it is for question 1.3 | ||
|
|
||
| const completeBookList = [ |
Contributor
There was a problem hiding this comment.
You create an array instead of an object as was asked in the instructions. Please look at the example I provided during the class.
You can find it here in the video: https://youtu.be/xKekzhG1kKM?t=108
Week1/homework/app.js
Outdated
|
|
||
| const coverImage = document.createElement('img'); | ||
| bookTitle.appendChild(coverImage); | ||
| const imgTarget = obj[i].id; |
Contributor
There was a problem hiding this comment.
You should create a separate loop to add the cover images like it is mentioned in the instructions.
Author
There was a problem hiding this comment.
I am so sorry.
I have already implemented the changes more than a week ago. I forget to inform you about it, terribly sorry for that.
They are ready for your review and approve, please.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.