This repository was archived by the owner on May 14, 2024. It is now read-only.
added javascript3 homework week2 #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harditsingh
reviewed
Jul 1, 2018
harditsingh
left a comment
harditsingh
left a comment
There was a problem hiding this comment.
Good job Dumie! Your code looks very clean and organized. I have some comments though, read below. Best of luck!
| }); | ||
| }); | ||
| data.forEach(repository => { | ||
| const listItem = createAndAppend('option', select); |
There was a problem hiding this comment.
The options in the drop-down menu are not sorted
| contributorsList.setAttribute('id', 'contributors_preview'); | ||
|
|
||
| select.addEventListener('change', (event) => { | ||
| const newUrl = 'https://api.github.com/repos/HackYourFuture/' + event.target.value; |
There was a problem hiding this comment.
You should not put a URL inside a function, this makes it harder to reuse code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am really sorry for submitting my homework late.