This repository was archived by the owner on May 14, 2024. It is now read-only.
JS3 week1 #66
Closed
JS3 week1 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
approved these changes
Aug 27, 2018
Contributor
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi Donald, as I did your review in class and you already applied my feedback I'll just approve your homework now without further comment (except for tip, see below). Again, good job!
| fetchJSON(url, (err, data) => { | ||
| const root = document.getElementById('root'); | ||
| const root = document.getElementById("root"); | ||
| const header = createAndAppend("header", root, { "class": "header" }); |
Contributor
There was a problem hiding this comment.
You do not need to enclose the property names such as class in quotes. If a property name of an object conforms to the rules of a JavaScript variables name (e.g. no spaces or special characters in the name) you can leave out the quotes. Of course, for the values you do need quotes if they are strings.
Author
There was a problem hiding this comment.
Hi Jim, thank you so much for your feedback, I have considered your advise in the homework for week 2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.