This repository was archived by the owner on May 14, 2024. It is now read-only.
Week2 Homework #87
Closed
Week2 Homework #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
reviewed
Sep 3, 2018
Contributor
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @acimanx, as I mentioned yesterday, this way too much code and so much different from what was asked in the assignment that I cannot give you feedback on this as a homework submission. I do note that you are using promises, which was part of the homework, although I do not see you catching errors.
Again, this looks impressive, but not as the asked-for homework. Since you are now engaged with the next module I will not request changes, and just leave this as a comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.