Skip to content

Revert "Added nonfunctional profile picture edit and delete icons"#315

Merged
stasel merged 2 commits intomainfrom
revert-265-frontend/profile-picture-editor-buttons
Apr 14, 2026
Merged

Revert "Added nonfunctional profile picture edit and delete icons"#315
stasel merged 2 commits intomainfrom
revert-265-frontend/profile-picture-editor-buttons

Conversation

@stasel
Copy link
Copy Markdown
Member

@stasel stasel commented Apr 14, 2026

Reverts #312 due to a regression in the sidebar

Copilot AI review requested due to automatic review settings April 14, 2026 13:54
@HackYourFutures HackYourFutures temporarily deployed to dojo-revert-265-fronten-1wmpun April 14, 2026 13:54 Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts prior UI changes that introduced nonfunctional profile-picture edit/delete icons, addressing a sidebar regression by restoring the simpler sidebar/profile rendering and aligning component exports/imports accordingly.

Changes:

  • Remove the ProfilePictureModal overlay (edit/delete icon UI) and revert sidebar to render a plain Avatar.
  • Switch TraineeProfile and ProfileSidebar back to default exports and update imports.
  • Adjust sidebar layout/styling (theme-based background, height) to match the reverted implementation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
client/src/features/trainee-profile/profile/components/TraineeProfile.tsx Update ProfileSidebar import and change TraineeProfile to default export.
client/src/features/trainee-profile/profile/components/ProfilePictureModal.tsx Deleted to remove the nonfunctional hover edit/delete UI.
client/src/features/trainee-profile/profile/ProfileSidebar.tsx Revert to a simple Avatar (no modal/icons) and export default; minor layout/style adjustments.
client/src/features/trainee-profile/TraineePage.tsx Update import to use TraineeProfile default export.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/src/features/trainee-profile/profile/ProfileSidebar.tsx Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HackYourFutures HackYourFutures temporarily deployed to dojo-revert-265-fronten-1wmpun April 14, 2026 15:06 Inactive
@stasel stasel merged commit f9bdd8e into main Apr 14, 2026
1 check passed
@stasel stasel deleted the revert-265-frontend/profile-picture-editor-buttons branch April 14, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants