fix: log out frontend logic

[Dmytro-Doronin]

Fixed log out react query logic.

[Copilot]

Pull request overview

This PR aims to fix the logout React Query logic by changing from onSettled to onSuccess callback and updating the logout confirmation flow to use mutateAsync instead of mutate. The changes also include modifications to the mobile menu component and a default variant change for the ProfileIndicator component.

Changes:

• Updated logout mutation to use onSuccess instead of onSettled for better semantic clarity
• Modified logout confirmation to use async/await pattern with mutateAsync
• Removed onClick functionality from MobileMenuItem component and changed z-index value

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
client/src/features/auth/mutations/useLogoutMutation.ts	Changed callback from onSettled to onSuccess for logout mutation
client/src/components/auth/logoutConfirmation/LogoutConfirmation.tsx	Updated to use mutateAsync with async handler to close modal after logout
client/src/components/ui/mobileMenu/MobileMenu.tsx	Removed onClick prop from MobileMenuItem component and changed z-index from z-50 to z-1000
client/src/components/profileIndicator/ProfileIndicator.tsx	Changed default variant from "main" to "private"

Comments suppressed due to low confidence (1)

client/src/features/auth/mutations/useLogoutMutation.ts:16

• The logout mutation lacks error handling. Other mutations in the codebase (e.g., useLoginMutation.ts, useCreateAppointmentMutation.ts, useRegisterMutation.ts) include onError callbacks to handle failures. Consider adding an onError handler to notify users if logout fails, or to handle the failure gracefully by clearing local state even if the API call fails.

  return useMutation({
    mutationFn: logoutApi,
    onSuccess: () => {
      localStorage.removeItem("hadSession");
      triggerLogout();
    },
  });

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.