fix: prevent in-selecting-range highlight for days outside current month #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4350 When using a date range picker, selecting a start date and navigating to a different month would incorrectly highlight dates from the 1st to the same day number as the start date. This was because isInSelectingRange() didn't check if the day was outside the currently displayed month. Added an early return in isInSelectingRange() to prevent highlighting days that are displayed from adjacent months in the calendar grid. Also updated the renderDay test helper to use the day's actual month as the default instead of hardcoded month 0, and added 4 new tests to verify the fix.
Add openToDate prop to ensure the calendar opens to November 2025 regardless of the current date. Without this, when startDate is null and selectsRange is true, the calendar defaults to today's date. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6073 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 30 30
Lines 3595 3597 +2
Branches 1522 1540 +18
=======================================
+ Hits 3567 3569 +2
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4350
When using a date range picker, selecting a start date and navigating to a different month would incorrectly highlight dates from the 1st to the same day number as the start date. This was because isInSelectingRange() didn't check if the day was outside the currently displayed month.
Added an early return in isInSelectingRange() to prevent highlighting days that are displayed from adjacent months in the calendar grid.
Also updated the renderDay test helper to use the day's actual month as the default instead of hardcoded month 0, and added 4 new tests to verify the fix.