Support for PHPStorm 2020.2 version #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (union types support) - now a parameter can contain several class references [support for 2020.2 version] process all class references for parameter (union types support) - now a parameter can contain several class references fixup! [support for 2020.2 version] process all class references for parameter (union types support) - now a parameter can contain several class references
…atterns & migrate to non-atomic PsiComment structure
# Conflicts: # src/main/java/fr/adrienbrault/idea/symfony2plugin/config/ServiceLineMarkerProvider.java
Owner
|
@JetBrains @slapoguzov thank for support; its merged via #1531 and new version release for PhpStorm 2020.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several breaking changes are coming with PHPStorm 2020.2 version:
Generic types were added to function signatures from
LineMarkerProviderinterface. I just updated all implementations ofLineMarkerProviderin the project.Now type declarations are able to contain several
ClassReferences(for union types support) therefore a new wrapperPhpTypeDeclarationto get allClassReferencesfrom type declaration was introduced. (see more information here https://www.jetbrains.org/intellij/sdk/docs/products/phpstorm/php_open_api_breaking_changes.html).I found only one affected place in the project -
PhpElementsUtil#getMethodParameterTypeHints().Twig
PsiCommentused to be atomic, and now containsCOMMENT_START,COMMENT_TEXT,COMMENT_ENDtokens. I removedCOMMENT_START({#) andCOMMENT_END(#}) from doc patterns.