fix(dash): hide throughput chip when lemonade does not emit MB/s (#326)#328
Merged
Conversation
Gate the footer throughput chip on `L.throughput != null && L.throughput > 0` so it hides entirely instead of rendering "—" (or, worse, a synthetic "0.0 MB/s") when Lemonade's /v1/health does not surface `throughput_mbps`. Match the same null-honoring discipline as the queued + coresident chips landed in #221. Also document `buildStats()` in the mock harness to ban future "completeness" defaults of `throughput_mbps: 0.0` — throughput is sourced exclusively from /v1/health (see useLemondRollup), so synthesizing it on the /v1/stats fallback path would re-introduce the misleading chip the gate is designed to hide. Adds Playwright spec footer-throughput-chip-v3 covering all three states (positive renders "12.4 MB/s", undefined hides, zero hides). Closes #326 Refs #322 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8 tasks
This was referenced May 25, 2026
thinmintdev
added a commit
that referenced
this pull request
May 28, 2026
…lease-manifest (#389) Add docs/internal/v0.3-state.md as the canonical v0.3 ground-truth doc (repo HEAD, five-stream status with PR/issue citations, terminology canon, stale-memory list, open blockers, ADR index). Writers cite this to stop triangulating PLAN.md + auto-memory + GH issues per word. Add ADR-0015 (Draft, alpha.2 target) — hal0 is an MCP host platform. Generalises ADR-0013's per-agent allow-list pattern to third-party MCP *servers*: registry at /etc/hal0/mcp/servers/<name>.toml, systemd template hal0-mcp@<name>.service, slot-style lifecycle states, curated catalog at installer/manifests/mcp-catalog.toml. Closes the gap the hal0_mcp_host_platform auto-memory calls out and the design behind issue #224's placeholder install-from-URL UI. Add ADR-0017 (Accepted) — bell+inbox approval UX for destructive MCP calls. Documents the contract shipped via Epic #322 (PRs #321 #328 #329 #330 #332): every MCP tool is classified READ-ONLY or DESTRUCTIVE via MCP annotations, unclassified defaults to DESTRUCTIVE, no per-agent trust override, pending forever. Third-party MCPs per ADR-0015 inherit the contract. Refresh release-manifest.md against v0.2/v0.3 reality. The runtime is no longer v0.1.x toolbox containers — it's the Lemonade embeddable tarball + the FastFlowLM .deb. Add optional `lemonade` and `flm` manifest blocks mirroring the installer's LEMONADE_* / FLM_* pins. Mark `toolbox_images` as historical (retained for out-of-tree consumers). Switch CF Pages references to Vercel per the actual deploy path. Light fix in api-errors.md: the 401 / auth.required example was documented as enforced by ADR-0001's FastAPI auth layer, which ADR-0012 removed entirely in v0.3.0-alpha.1. Reframe as a shape contract for any future re-introduced auth and for the MCP identity middleware, not a live request path. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
thinmintdev
added a commit
that referenced
this pull request
May 28, 2026
…rough + gut installer auth section (#390) - docs/operate/lemonade.md (new, .md canonical): operator reference for the v0.2 Lemonade runtime — what it is, where state lives, the /v1/* proxy + dispatcher fallthrough (PRs #248/#277), slot ↔ Lemonade model mapping (PRs #281/#282), max_loaded_models = 8 LRU cap (PR #283), per-type LRU eviction per ADR-0008 (supersedes nuclear-evict ADR-0007), OFFLINE-on-eviction (PR #276), and the three known v0.3 caveats (Vulkan KV gauge missing, whisper RUNPATH workaround, GPU cleanup unload hang). - docs/dashboard/v3.md (new, .md canonical, new docs/dashboard/ dir): page-by-page tour of the v3 React dashboard shipped in v0.3.0-alpha.1 (PR #235). Covers the shell + Mock-badge convention, /dashboard (system overview after #356), /chat (real surface per #309/#314/#315/#351), /slots (sidebar mirror per #357 + #344 UX sweep), /models (#313/#319/#353), /mcp (#304/#300), /agents (Peers per #299), /memory (graph #297, throughput #308), Settings (no Auth tab post-ADR-0012), and the footer journal (Epic #322 — PRs #321/#328/#329/#330/#332). Mock-fallback issues linked via the dashboard-v3 label, not enumerated. - installer/README.md: gut ~95 lines of stale auth prose (Caddy, Bearer-token mint/use/revoke, first-run OTP claim wizard, HAL0_AUTH_ENABLED/HAL0_AUTH_DISABLED, password recovery, basic_auth upgrade path, the TLS recipe). Replace with one paragraph pointing at docs/operate/auth.mdx for the reverse-proxy recipe and docs/agents/identity.md for the X-hal0-Agent identity model. Auth was removed in v0.3.0-alpha.1 per ADR-0012; the README hadn't caught up. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The footer throughput chip used to render
${L.throughput} MB/swith a—fallback when Lemonade's/v1/healthdid not surfacethroughput_mbps. This always-on chip looked broken on installs where the metric isn't emitted — and would have shown a misleading "0.0 MB/s" if any layer of the fallback chain ever defaulted to 0. The chip now hides entirely when throughput is null or 0, matching the same null-honoring discipline the queued + coresident chips got in #221. A value of0from a live system actually serving traffic is just as meaningless as null, so both states collapse to "hide".buildStats()in the mock harness gets a banner comment explicitly banning future "completeness" defaults ofthroughput_mbps: 0.0— throughput is sourced exclusively from/v1/health(viauseLemondRollup), so synthesizing it on the/v1/statsfallback path would re-introduce the misleading chip the gate is designed to hide.useLemondRollupwas audited and already coerces correctly (h?.throughput_mbps ?? null) — no change needed there.Files changed
ui/src/dash/chrome.jsx— gate the throughput chip onL.throughput != null && L.throughput > 0ui/src/api/mock.ts— documentbuildStats()to ban syntheticthroughput_mbps: 0.0defaultsui/tests/e2e/specs/footer-throughput-chip-v3.spec.ts— new Playwright spec, 3 casesTest plan
npm --prefix ui run typecheck— cleannpm --prefix ui run build— clean (533 KB JS / 84 KB CSS)grep -r "throughput_mbps.*0\.0" ui/dist/— no matchnpx playwright test footer-throughput-chip-v3 footer-chips-v3— 5/5 passed (3 new + 2 existing footer: queued chip hardcoded to 0 + NPU coresident derived from heuristic #221 regression)Closes #326
Refs #322