fix(dash): render real bundle name in banners + install progress (#214)#331
Merged
Merged
Conversation
The post-install hero ("Welcome to hal0 — hal0-Pro is loaded"), the
re-entered-picker banner ("You currently have hal0-Pro installed"),
and the install-progress heading all hardcoded `hal0-Pro` regardless
of which tier the operator actually picked. Carries over from the
v2 → v3 React rewrite.
- Backend: `GET /api/install/state` now includes `bundle: {name,
npu_opt_in, skipped, chosen_at, assignments} | null` sourced from
`bundle_store.read_choice()`. `bundle` is null before a pick and
`bundle.skipped=true` for the "configure manually" branch.
- UI: new `useInstallState()` hook (+ `bundleNameOr()` resolver) wraps
the endpoint. `BannerStack` interpolates `{bundleName}` (and any
view-supplied vars) in heading/eyebrow/body so a single catalog
entry tracks live state. Catalogs in `primitives.jsx` and
`useBannerStore.ts` switched from literal `hal0-Pro` to
`{bundleName}`.
- `FirstRunProgress` now takes `bundleId` and renders the picked tier
name in "Installing hal0-Pro…" — the only place this string is
actually rendered today, but it was wrong for every tier other than
Pro.
The hardcoded `(Qwen3.6-27B-MTP)` parenthetical in the post-install
hero is dropped — it pretended to know which primary-slot model was
loaded; the persona dropdown copy stays accurate without it.
Closes #214.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
a1ee9cf to
3d8ec1b
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/install/statenow includes the persisted bundle pick (bundle: {name, npu_opt_in, skipped, …} | null) sourced frombundle_store.read_choice().useInstallState()hook +bundleNameOr()resolver in the UI.BannerStackinterpolates{bundleName}(and view-supplied vars) so a single banner-catalog entry tracks live state. Headings inprimitives.jsx+useBannerStore.tsswitched from literalhal0-Proto{bundleName}.FirstRunProgresstakesbundleIdand renders the picked tier in "Installing hal0-Pro…". This was the only place the hardcode actually rendered today; the banner-catalog entries are now correct for when they get toggled active.Dropped the
(Qwen3.6-27B-MTP)parenthetical in the post-install hero — it pretended to know which primary model was loaded.Test plan
pytest tests/api/test_installer_routes.py— 14 pass (3 new)ruff check+ruff format --checkhal0-Defaultin the wizard → progress card reads "Installing hal0-Default…"; post-install hero (when toggled in Tweaks demo) reads "Welcome to hal0 — hal0-Default is loaded"Part of the v3 dashboard mock-cleanup series (tracker #234). Follows up on PR #321 (Settings → Updates wire-up).
🤖 Generated with Claude Code