docs(adr): flip ADR-0001 to Accepted + add Outcome section (#57)#65
Merged
Conversation
ADR-0001 (Collapse edge auth into FastAPI) is implemented. Child A (#58 — FastAPI password auth), Child B (#59 — Caddyfile reduction + --no-tls), and Child C (#60 — docs pass) all landed. Flips the header from Proposed → Accepted, records proposal/acceptance dates separately, names the implementing PRs, and appends an Outcome section summarizing what shipped against the original Decision. Adds #28 (the critical basic_auth ordering bug) to the closed-on-land list per tests/harness/FINDINGS.md §10. README.md and installer/README.md were already brought into line with the v1 single-FastAPI-layer reality in PR #60 — no further changes needed there.
thinmintdev
force-pushed
the
main
branch
2 times, most recently
from
0c4ce34 to
5458a0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57 — ADR-0001 (Collapse edge auth into FastAPI) is implemented. PR #60 already brought the README, installer/README, PLAN.md, harness FINDINGS, and api-errors docs into line with the single-FastAPI-auth-layer reality. This PR closes the last open hedge: the ADR header itself, which still said
Status: Proposed.What
docs/adr/0001-collapse-edge-auth-into-fastapi.mdStatus: Proposed→Status: Accepted. SplitDateintoDate proposed: 2026-05-17+Date accepted: 2026-05-21. AddedImplementing PRs:line naming Child A (feat(auth): password + session cookies, dual cookie/Bearer middleware (ADR-0001 Child A — refs #54) #58), Child B (feat(install): collapse Caddy to TLS-only, drop PUBLIC_PATHS, add --no-tls (ADR-0001 Child B — refs #54) #59), Child C (docs: close out ADR-0001 — installer + FINDINGS + close #43/#51 (Child C — refs #54) #60).Closes (on land): #43, #51→Closed on land: #28, #43, #51(past tense, plus Caddy basic_auth swallows PUBLIC_PATHS allowlist — first-run wizard unbootstrappable #28 which the harness FINDINGS already recognised as fixed by architecture removal).--no-tlsflag, FastAPI password auth + session cookies,PUBLIC_PATHSfrozenset deletion, regression test guarding the deletion, and the resolution of harness findings docs(release-manifest): document hal0-web releases hosting flow #10/feat(harness): durable end-to-end test harness for installer/CLI/runtime #16/fix(cli): split slot create --backend into --provider + --hardware #21.What was already done (PR #60)
Sanity-checked the spec's other targets —
README.mdandinstaller/README.mdare already free of stale dual-layer language. The remaining--auth=basic/edge authmentions ininstaller/README.mdlive in the Upgrade notes (pre-v1) subsection, where they're correctly framed as historical for users upgrading off the old path. PLAN.md §1 was rewritten in PR #60 and matches the v1 reality.docs/api-errors.md401 section links the ADR + PR #58 endpoints. Repo-wide grep for hedge phrases (when ADR-0001 lands,pending ADR-0001, etc.) returns zero hits.No code, no tests, no installer/install.sh — pure docs-only.
🤖 Generated with Claude Code