Skip to content

committing all wip#1

Draft
Hammond95 wants to merge 1 commit intomasterfrom
trying-to-update-for-mac15
Draft

committing all wip#1
Hammond95 wants to merge 1 commit intomasterfrom
trying-to-update-for-mac15

Conversation

@Hammond95
Copy link
Owner

No description provided.

@Hammond95 Hammond95 marked this pull request as draft August 11, 2025 22:00
Comment on lines +4518 to +4537
<key>ControllerHost</key>
<dict>
<key>CFBundleIdentifier</key>
<string>com.mice.driver.Xbox360Controller</string>
<key>IOCFPlugInTypes</key>
<dict>
<key>F4545CE5-BF5B-11D6-A4BB-0003933E3E3E</key>
<string>360Controller.kext/Contents/PlugIns/Feedback360.plugin</string>
</dict>
<key>IOClass</key>
<string>Xbox360Peripheral</string>
<key>IOKitDebug</key>
<integer>65535</integer>
<key>IOProviderClass</key>
<string>IOUSBHostDevice</string>
<key>idProduct</key>
<integer>654</integer>
<key>idVendor</key>
<integer>1118</integer>
</dict>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to replace all instances of IOUSBDevice with IOUSBHostDevice instead of creating a new ControllerHost dictionary.

//#define PROTOCOL_DEBUG

OSDefineMetaClassAndStructors(WirelessGamingReceiver, IOService)
OSDefineMetaClassAndStructorsWithInit(WirelessGamingReceiver, IOService)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have stayed OSDefineMetaClassAndStructors.

IOUSBInterface *interface;



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moving of these declarations to inline causes Clang to complain due to the use of goto: in this function.

Comment on lines -365 to +362
connections[i].controllerIn->Abort();
connections[i].controllerIn->abort(kAbortOptionNone, kIOReturnAborted, this);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where you got kAbortOptionNone, but that doesn't seem to be in the macOS' current SDKs.

Comment on lines -276 to +279
55B636FA18C1054F00CE933D /* English */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.strings; name = English; path = English.lproj/InfoPlist.strings; sourceTree = "<group>"; };


55B636FB18C1054F00CE933D /* English */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.strings; name = English; path = English.lproj/InfoPlist.strings; sourceTree = "<group>"; };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule, when I manually edit a .pbxproj file, I usually move a file in the Xcode window or something to regenerate the project file. It usually takes care of any added newlines or comments that no longer match up with the actual content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants