refactor(cli): replace String output with typed OutputMode enum#2
Merged
HanSoBored merged 3 commits intomainfrom Apr 23, 2026
Merged
refactor(cli): replace String output with typed OutputMode enum#2HanSoBored merged 3 commits intomainfrom
HanSoBored merged 3 commits intomainfrom
Conversation
- Remove SymbolStatus enum from symbol.rs - Remove status field from Symbol struct - Remove by_status tracking from Statistics - Remove related dead code and tests
- Remove status breakdown from TextFormatter - Remove by_status filter from SymbolFilter - Remove StatusCount from JSON output - Update tests to reflect status removal
- Add OutputMode enum (Text, Json, Tui) with ValueEnum derive - Replace String output field with OutputMode type - Remove is_json_output() helper method - Update CLI tests for new enum type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary