style(tests): fix MISS_HIT operator_after_continuation lint#119
Merged
style(tests): fix MISS_HIT operator_after_continuation lint#119
Conversation
…rdInfo Move trailing `&&` to end of previous line in tryCloseInfoModal teardown helper so MISS_HIT mh_style passes. CI MATLAB Lint job (run 25562812581) flagged this as `operator_after_continuation` after PR #118 merged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'FastSense Performance'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: f0c6072 | Previous: ddba284 | Ratio |
|---|---|---|---|
Downsample mean (1M) |
1.339 ms |
1.182 ms |
1.13 |
Downsample mean std(1M) |
0.202 ms |
0.019 ms |
10.63 |
Downsample mean std(5M) |
0.226 ms |
0.189 ms |
1.20 |
Render mean std(5M) |
2.02 ms |
1.519 ms |
1.33 |
Zoom cycle mean std(5M) |
0.936 ms |
0.701 ms |
1.34 |
Instantiation mean std10M) |
2.049 ms |
0.818 ms |
2.50 |
Zoom cycle mean std10M) |
0.728 ms |
0.447 ms |
1.63 |
Zoom cycle mean (50M) |
17.866 ms |
14.232 ms |
1.26 |
Downsample mean ( std00M) |
4.856 ms |
0.664 ms |
7.31 |
Render mean ( std00M) |
3.805 ms |
3.147 ms |
1.21 |
Zoom cycle mean (100M) |
18.644 ms |
15.478 ms |
1.20 |
Downsample mean ( std00M) |
1.758 ms |
0.664 ms |
2.65 |
Instantiation mean ( std00M) |
278.839 ms |
78.586 ms |
3.55 |
Dashboard create+render stdmean |
29.591 ms |
18.028 ms |
1.64 |
Dashboard live tick stdmean |
0.076 ms |
0.048 ms |
1.58 |
Dashboard page switch stdmean |
1.123 ms |
0.146 ms |
7.69 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @HanSur94
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move trailing
&&to end of previous line intryCloseInfoModalteardown helper so MISS_HITmh_stylepasses.Background
PR #118 (info modal) merged green per local static checks but the CI MATLAB Lint job (run 25562812581) flagged:
Local executor only ran
mcp__matlab__check_matlab_code(mlint), notmh_style. This patch fixes the one offending continuation.Test plan
mh_stylepasses locally (will be re-verified by CI)🤖 Generated with Claude Code