Bug-find session 260526: info-icon survival + 1000-pt preview cap#163
Merged
Conversation
… -> 1000 - DashboardEngine.computePreviewEnvelopeReturning_: change min(400, ...) -> min(1000, ...) so wide windows (>=2000 px) drive proportionally more preview detail in the bottom slider strip. - Update doc-comment on computePreviewEnvelope and inline comment in computePreviewEnvelopeReturning_ to report new range [50, 1000]. - Update consistency comment in tests/test_dashboard_preview_overlay.m (no assertion change — the test only asserts numel(xd) >= 4). - Intentionally NOT adding cache invalidation: PreviewNBuckets_ is cached on DashboardEngine, so a running demo must restart (or trigger the existing resize-invalidation at line 2241) to pick up the new cap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add PLAN.md and SUMMARY.md for quick task 260526-pqz. - Update STATE.md "Quick Tasks Completed" table with new row. Task delivered: raised per-signal slider-preview cap from 400 -> 1000 buckets in DashboardEngine.computePreviewEnvelopeReturning_. Static analysis clean (mh_lint + mh_style); MATLAB tests pass (envelope 7/7, overlay 10/10); Octave runs as expected (preview_envelope 2/2 with pre-existing skips; preview_overlay skipped — pre-existing TimeRangeSelector guard). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
addPlantLogToggle hardcoded xPL for a 3-button right cluster, but the FastSenseWidget chrome carries a 4-button cluster. Without a reflowChrome_ pass after L rebuild, the recreated L button landed on top of InfoIconButton, visually swallowing the i icon after every toggle. The initial render was rescued by the reflowChrome_ at the end of realizeWidget; callback-driven rebuilds were not. Fix: call DashboardLayout.reflowChrome_ at the end of addPlantLogToggle (wrapped in try/catch so a reflow failure can never break the toggle itself). Adds regression tests covering one and multiple toggle cycles. Fixes two pre-existing stale tests that pinned the 3-button-cluster layout. Closes debug session: .planning/debug/260526-info-icon-vanishes-after-plantlog-toggle.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes surfaced during a live bug-hunt session on the industrial-plant demo:
d2bb50f) —DashboardLayout.addPlantLogTogglehardcoded the L button's x position for a 3-button right cluster, so on callback-driven L on→off rebuilds it landed on top ofInfoIconButton, visually occluding the i icon. Fix: callreflowChrome_at the end ofaddPlantLogToggle(try/catch'd) so the canonical 4-button-cluster layout re-applies after every rebuild. Includes regression tests in both the class-based suite and function-style test file.834b43c) —DashboardEngine.computePreviewEnvelopeReturning_clampsnBucketsfrom a figure-pixel-derived value; the cap was 400 buckets/signal. Bumped to 1000 so the bottom slider preview can show more detail on wide screens. Doc comments updated. One stale[50, 400]comment intest_dashboard_preview_overlay.malso corrected.GSD artifacts (committed alongside) document the quick task in
.planning/quick/260526-pqz-…/.Test plan
tests/test_dashboard_preview_envelope.m— 7/7 (MATLAB R2025a), 2/2 (Octave 11.1.0)tests/test_dashboard_preview_overlay.m— 10/10 (MATLAB)tests/suite/TestDashboardLayoutPlantLogToggle.m(new regression testtestInfoIconSurvivesToggleOnOff) — passestests/test_dashboard_layout_plant_log_toggle.m(new sub-test) — passesmh_lint+mh_styleclean on both edited files🤖 Generated with Claude Code