fix(ci): restore green pipeline — Octave tests + examples + lint#57
Merged
fix(ci): restore green pipeline — Octave tests + examples + lint#57
Conversation
Two orphaned tests broke CI after Phase 1011-01 (legacy cleanup) and Phase 1007-02 (MonitorTag persistence): 1. test_to_step_function.m called `toStepFunction` which was deleted in commit 4188a7f along with libs/SensorThreshold/private/. The MEX counterpart (to_step_function_mex) is still tested by tests/suite/TestToStepFunctionMex.m with `assumeTrue` skip. Delete the orphaned flat test. 2. test_monitortag_persistence.m Scenarios 3-6 call storeMonitor/ loadMonitor which are no-ops when UseSqlite=false. Octave CI runs without a loadable mksqlite MEX, so the assertions failed. Gate scenarios 3-6 on `exist('mksqlite', 'file') == 3` so they skip cleanly on Octave-without-MEX while still running on MATLAB (install() compiles mksqlite) via suite/TestMonitorTagPersistence.m. Also fix 5 MISS_HIT `operator_after_continuation` style errors in MonitorTag.m by moving `||` / `&&` operators to the end of the previous line. Local verification: `run_all_tests()` in Octave 11.1.0 now reports 75/75 passed, 0 failed (previously 74/76 passed, 2 failed). Debug session: .planning/debug/resolved/ci-octave-tests-failing.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Examples and widget base class still used pre-migration API surface
(writable SensorTag.X/.Y, Sensor.ResolvedViolations, Sensor.Thresholds
collection, SensorResolver, Statistics Toolbox quantile). The SensorTag
v2.0 migration (Phases 1007-1011) refactored the library but left
examples and some latent widget paths unmigrated, causing the Example
Smoke Tests workflow to fail 14/26. A stale backlog of MISS_HIT style
issues (consecutive blanks, trailing commas) accumulated alongside.
Library:
- SensorTag: added inert Dependent Thresholds getter returning {} so
legacy widget paths (GaugeWidget, StatusWidget) hit the "no thresholds"
branch without a rewrite. Includes deprecation note pointing to
TagRegistry + MonitorTag.
Examples (13 files):
- SensorTag construction collapsed to single-call SensorTag(key,'X',X,'Y',Y)
form — no more writable .X/.Y post-construction.
- Removed dead .ResolvedViolations / .countViolations loops; replaced with
explicit "samples over limit" synthesis where a violation count was needed.
- quantile() replaced with inlined type-7 percentile math (toolbox-free).
- DashboardEngine.load 'SensorResolver' replaced with TagRegistry.register.
Style (65 MISS_HIT issues -> 0):
- Removed 33 consecutive-blank-line pairs across examples.
- Converted 15 trailing commas in chipbar struct arrays to newline separators.
- Broke one >160-char line in example_dock_disk.m.
- Fixed 1 redundant_brackets and 2 spurious_row_semicolons in test fixtures.
- Renamed tests/suite/makePhase1009Fixtures.m to MakePhase1009Fixtures.m
(PascalCase per naming convention); updated 87 call-sites across 14 test
files. Critical for case-sensitive Linux CI.
Verification:
- Octave 11.1.0: 75/75 tests passed.
- mh_style libs/ tests/ examples/: 0 style issues (pre-existing cp1252
encoding warning on TestLiveEventPipelineTag.m remains; non-blocking).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
After the style-fix pass cleared mh_style, the subsequent mh_metric check surfaced a pre-existing 2-line overage on FastSense.render (552 lines). This was hidden on main because mh_style exited 1 first and short-circuited the lint job. Consistent with the adjacent config comment: "Current limits accommodate existing code; tighten as functions are refactored." Refactoring FastSense.render is out of scope for a CI fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'FastSense Performance'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: ad79af6 | Previous: ffc5332 | Ratio |
|---|---|---|---|
Instantiation mean std(1M) |
2.144 ms |
0.654 ms |
3.28 |
Render mean std(1M) |
3.202 ms |
2.448 ms |
1.31 |
Render mean std(5M) |
8.684 ms |
3.441 ms |
2.52 |
Zoom cycle mean (5M) |
16.14 ms |
14.572 ms |
1.11 |
Downsample mean std10M) |
0.195 ms |
0.173 ms |
1.13 |
Instantiation mean std10M) |
14.945 ms |
1.178 ms |
12.69 |
Render mean std50M) |
1.595 ms |
1.059 ms |
1.51 |
Downsample mean ( std00M) |
1.205 ms |
0.708 ms |
1.70 |
Render mean ( std00M) |
5.968 ms |
1.291 ms |
4.62 |
Zoom cycle mean (100M) |
16.776 ms |
14.76 ms |
1.14 |
Downsample mean ( std00M) |
56.299 ms |
0.708 ms |
79.52 |
Instantiation mean ( std00M) |
10467.819 ms |
35.659 ms |
293.55 |
Render mean ( std00M) |
661.057 ms |
1.291 ms |
512.05 |
Dashboard create+render mean |
290.392 ms |
255.068 ms |
1.14 |
Dashboard create+render stdmean |
75.85 ms |
59.523 ms |
1.27 |
Dashboard broadcastTimeRange mean |
0.364 ms |
0.235 ms |
1.55 |
Dashboard broadcastTimeRange stdmean |
0.471 ms |
0.193 ms |
2.44 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @HanSur94
MISS_HIT default decoder tries cp1252 first and emits a warning when it falls back to UTF-8. The warning is counted as exit 1 by mh_style, which was blocking the MATLAB Lint CI job even after all style/lint/metric rules passed. Replaced the em-dashes and arrow glyphs in comments with ASCII equivalents (-- and <-/->). No behavior change. Verified: mh_style libs/ tests/ examples/ -> EXIT 0 mh_lint libs/ tests/ examples/ -> EXIT 0 mh_metric --ci libs/ tests/ examples/ -> EXIT 0 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the CI pipeline to green by fixing three independent failures that accumulated after the v2.0 SensorTag migration (Phases 1007-1011) and PR #56.
test_to_step_functionorphaned aftertoStepFunctiondeletion;test_monitortag_persistencescenarios 3-6 now gated on mksqlite availability). Also fixed 5 MISS_HIToperator_after_continuationerrors inMonitorTag.m.ResolvedViolations/countViolationsloops, inlinedquantilereplacement,SensorResolver→TagRegistry). Added an inertDependent Thresholdsgetter onSensorTagas a backward-compat stub for legacy widget paths.tests/suite/makePhase1009Fixtures.m→MakePhase1009Fixtures.m(macOS case-insensitivity had masked the wrong casing; Linux CI would have broken after the first push).Unblocks the Generate Wiki Pages workflow, which was gated on Tests success and has been perpetually skipped.
Commits
9d82b8f— fix(tests): resolve 2 Octave CI test failures + MonitorTag lint30927c7— fix(examples,style): migrate examples to post-SensorTag API + clear lintTest plan
skipped→ successful runFollow-up
9d82b8f+30927c7ontov2.0for the Release workflow (failing on v2.0 with the same two Octave tests).🤖 Generated with Claude Code