chore(mex): ship multi-platform prebuilt binaries (6/7 platforms)#92
Merged
chore(mex): ship multi-platform prebuilt binaries (6/7 platforms)#92
Conversation
…tave Linux/Windows Adds prebuilt MEX binaries for 5 new platforms and refreshes the existing macOS-ARM64 set, all from CI run 25051632929 (refresh-mex-binaries workflow_dispatch). New platforms: - MATLAB Linux x86_64 (.mexa64) - MATLAB macOS x86_64 (.mexmaci64) - Octave Linux x86_64 (octave-linux-x86_64/*.mex) - Octave macOS ARM64 (octave-macos-arm64/*.mex — refreshed too) - Octave Windows x86_64 (octave-windows-x86_64/*.mex) Refreshed: - MATLAB macOS ARM64 (.mexmaca64, freshly compiled) Known gap: MATLAB Windows x86_64 (.mexw64) is NOT included — that platform's CI build produced no .mexw64 files (root cause TBD; install() ran without erroring but emitted nothing). Windows MATLAB users will fall back to local compilation via install.m on first run. Bypassing the auto-PR mechanism: refresh-mex-binaries.yml's aggregator download-artifact step has a path bug (LCA-trimming makes artifact internal roots `FastSense/...` not `libs/FastSense/...`, so files extract outside libs/ and create-pull-request sees no diff). Will fix in a follow-up; for this release the binaries are committed manually. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'FastSense Performance'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 8686ada | Previous: c2ffac6 | Ratio |
|---|---|---|---|
Render mean std(1M) |
2.255 ms |
0.914 ms |
2.47 |
Downsample mean std(5M) |
0.246 ms |
0.041 ms |
6 |
Downsample mean (10M) |
23.305 ms |
19.343 ms |
1.20 |
Render mean std10M) |
2.293 ms |
1.824 ms |
1.26 |
Downsample mean (50M) |
121.719 ms |
99.207 ms |
1.23 |
Instantiation mean (50M) |
1620.181 ms |
1267.851 ms |
1.28 |
Instantiation mean std50M) |
46.81 ms |
7.788 ms |
6.01 |
Downsample mean (100M) |
249.233 ms |
195.388 ms |
1.28 |
Downsample mean ( std00M) |
0.54 ms |
0.262 ms |
2.06 |
Instantiation mean (100M) |
3254.644 ms |
2385.463 ms |
1.36 |
Instantiation mean ( std00M) |
215.91 ms |
63.283 ms |
3.41 |
Render mean ( std00M) |
3.566 ms |
3.071 ms |
1.16 |
Downsample mean (500M) |
1260.47 ms |
1003.525 ms |
1.26 |
Downsample mean ( std00M) |
1.788 ms |
0.262 ms |
6.82 |
Instantiation mean (500M) |
26081.484 ms |
21827.502 ms |
1.19 |
Instantiation mean ( std00M) |
293.847 ms |
63.283 ms |
4.64 |
Dashboard live tick stdmean |
0.472 ms |
0.278 ms |
1.70 |
Dashboard page switch mean |
0.188 ms |
0.153 ms |
1.23 |
Dashboard broadcastTimeRange stdmean |
0.026 ms |
0.021 ms |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @HanSur94
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds prebuilt MEX binaries for 5 new platforms and refreshes the existing macOS-ARM64 set. After merge, tagging v2.1.1 will produce a release archive that ships compilation-free on most platforms.
All binaries built from CI run 25051632929 (refresh-mex-binaries.yml workflow_dispatch on
main@ c2ffac6).Known gap
MATLAB Windows x86_64 not included. Its CI build step "Compile via install()" ran without throwing but emitted no
.mexw64files. Root cause TBD (separate investigation). Windows MATLAB users will fall back to local compilation viainstall.mon first run — which has worked previously, so no functional regression.Why this PR is hand-authored vs. an auto-PR
refresh-mex-binaries.yml's aggregator has a path bug:actions/upload-artifact@v7trims the LCA (libs/), so each artifact's internal root isFastSense/...notlibs/FastSense/.... Whendownload-artifact merge-multiple: trueextracts to the workspace root, files land atworkspace/FastSense/...— outsidelibs/. The aggregator'sfind libsstep finds nothing new,peter-evans/create-pull-requestsees no diff, exits silently. Worth fixing in a follow-up; for this release the binaries are committed manually.Test plan
octave-linux-x86_64/*.mex)🤖 Generated with Claude Code