Audio Track Dependent Subtitle Defaults

[Haravikk]

This enhancement proposal is to enable configurable default subtitles that are dependent upon the audio track matched by the audio defaults.

The idea is to enable Handbrake to automatically select subtitles if none of the desired audio languages is found. For example, if my audio default is English, but I encode an anime series with only Japanese audio, then Handbrake could automatically select English subtitles (if available), however for a series with English audio it would skip subtitles entirely.

In terms of interface, I could see this being added to the Configure Defaults window for subtitles; from here it would be possible to select from among the configured audio defaults and specify which ones should/should not include subtitles, with a default option for all other languages. But this may be complex, so any simpler solution may be fine too.

Basically for my own personal use case my default is to only include English audio (where available), in which case I don't need subtitles, but when that audio is unavailable I would like to have English subtitles included automatically.

If automating this is too complex, then my other issue #324 may cover this use-case well enough that it's not a problem. Hopefully a developer can comment on what implementing this would look like so that can be decided.

[jstebbins]

I'm not sure if the other GUIs ever implemented the UI elements for this. But there is a preset key already for this use case (SubtitleAddForeignAudioSubtitle TRUE/FALSE). What this key enables is pretty much what you've described. If the first audio track language does not match the preferred subtitle language (as defined by the first language in the subtitle language list), then the first subtitle track with the preferred subtitle language is added.

The Linux GUI has a checkbox that enables this preset key in the subtitle defaults pane. The checkbox is labeled "Add XXX subtitle track if default audio is not XXX" where XXX is replaced by the preferred subtitle language. The checkbox is disabled when the preferred subtitle language is not set.

I use this in all my personal presets along with the foreign audio search option in order to get the necessary subtitles in my encodes.

[Haravikk]

Ah, didn't realise that! It doesn't look like it's in the Mac GUI (or if it is I can't find it), in that case perhaps this issue should be considered a request to make sure it is added to all platforms?

In the mean time I'll try adding the option to my presets manually, thanks!

[bradleysepos]

@galad87 @sr55 Perhaps this is something to look at for 1.1.0?

[sr55]

I suppose but it's kind of awkward.

It's only relevant if selection behaviour = none. Otherwise it'll get added anyway.
It probably makes sens to grey out the checkbox and disable it on the linux GUI when First/All is selected.

[bradleysepos]

I would think it would only be irrelevant if the selection behavior doesn't already match the subtitle this would add? Perhaps @jstebbins can clarify how this works in the GTK GUI.

[sr55]

Subtitle selection is either First or All for any of the selected languages.

This feature relies on the first selected language. So, both first and all will add atleast one track of that language if it exsts on the source.

[bradleysepos]

Ah, I misread this:

The checkbox is labeled "Add XXX subtitle track if default audio is not XXX" where XXX is replaced by the preferred subtitle language. The checkbox is disabled when the preferred subtitle language is not set.

👓 👀

[jstebbins]

@sr55 good point. In my mind this feature was more like foreign audio scan from a users perspective, and it didn't occur to me that functionally, it's really more of a selection behaviour. It could easily be made into an option in the selection behaviour dropdown and the extra SubtitleAddForeignAudioSubtitle key can be eliminated. If you all prefer this from a UI perspective, I don't mind making this change.

[bradleysepos]

So, something like "First Matching Selected Languages, only when default audio differs"?