Conversation
The 0.1.4 fix incorrectly filtered ALL endpoints from the nodes list, which removed control plane nodes that legitimately appear in both. This broke configs like: - endpoints: [vip, cp1, cp2, cp3] - nodes: [cp1, cp2, cp3, w1, w2] The corrected logic now only filters endpoints that are NOT also in the nodes list (true vIPs/load balancers). Control plane nodes appearing in both lists are preserved. Also fixed kubeconfig and etcd APIs to not use node targeting - these only run on control plane nodes, so targeting workers returned empty results. Added log noise filtering for HTTP/gRPC libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.4 fix incorrectly filtered ALL endpoints from the nodes list, which removed control plane nodes that legitimately appear in both. This broke configs like:
The corrected logic now only filters endpoints that are NOT also in the nodes list (true vIPs/load balancers). Control plane nodes appearing in both lists are preserved.
Also fixed kubeconfig and etcd APIs to not use node targeting - these only run on control plane nodes, so targeting workers returned empty results. Added log noise filtering for HTTP/gRPC libraries.