fix(retry): fix sporadic "no request forwarding" errors when fetching discovery members through a VIP endpoint#17
Merged
Handfish merged 3 commits intoHandfish:mainfrom Jan 21, 2026
Conversation
Contributor
Author
|
I ran into this issue when having my Talos config set up like: context: mycluster
contexts:
mycluster:
endpoints:
- 192.168.9.11
- 192.168.9.12
- 192.168.9.13
- 192.168.9.21
- 192.168.9.22
- 192.168.9.23
nodes:
- 192.168.9.11
- 192.168.9.12
- 192.168.9.13
- 192.168.9.21
- 192.168.9.22
- 192.168.9.23Where it would just randomly fail at startup... |
- Replace unwrap() with unwrap_or_else to prevent panic - Shuffle fallback nodes to distribute load - Add unit tests for discovery member parsing - Fix formatting Small improvements to fix by: perfectra1n <jonfuller2012@gmail.com>
0be4b8e to
5df74ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sporadic "no request forwarding" errors when fetching discovery members through a VIP endpoint.
When the TUI queries discovery members via the VIP, the request may route to a control plane node that can't forward it, causing the
discovery_membersto be cleared. Therefore falling back to an empty node list, and the TUI showing empty/stale cluster data.Retry with fallback nodes, first tries VIP (2 retries), then queries each control plane node directly. I also set up to preserve cached data and don't clear
discovery_memberson error. Then finally, tertiary fallback where we useversionsdata as node source if discovery AND etcd both fail.talos-rs/src/talosctl.rsget_discovery_members_for_node_async()and update retry function to accept fallback node IPstalos-rs/src/lib.rstalos-pilot-tui/src/components/cluster.rstalos-pilot-tui/src/components/lifecycle.rsLet me know if you have any questions or any suggestions :)