[pull] main from spring-projects:main#428
Merged
pull[bot] merged 5 commits intoHandleCoding:mainfrom Apr 27, 2026
Merged
Conversation
fix: fix doKey() escaping in MariaDB, Oracle, and PgVector filter expression converters
- MariaDB: backtick-quote the metadata column identifier in the column name, and fix doKey() to JS-escape the key (\ and " for JSONPath) before SQL-escaping via emitSqlString(), rather than only doubling single quotes.
- Oracle and PgVector: move SQL single-quote escaping from OracleVectorStore and PgVectorStore into their respective converters, consistent with MariaDB.
Ensure JSON metadata keys are escaped in Pinecone and Chroma filter converter
- PineconeFilterExpressionConverter: emit keys via emitJsonValue() so " and \ cannot break
out of JSON object keys and inject operators (e.g. $or) into Chroma/Pinecone where documents.
- Adding tests in Pinecone and Chroma to ensure that the FilterExpressionConverter's doKey() implementation
properly JSON serializes the key so that any double quotes, and \ charaters are correctly escaped in the
generate JSON string for the key.
doKey fixes for Milvus, MongoDB, Neo4j and OpenSearch
Escape Lucene query_string metadata keys via emitLuceneString
Couchbase: JSON-escape metadata filter keys with emitJsonValue
Fix gemfire vector store filter expression doKey (escape chars by using emitLuceneString).
Add double quotes around the entire metadata.key string in ElasticSearch filter expression as emitLuceneString does not escape spaces.
Fix Weaviate vector store for filter expression key handling
Use emitJsonValue utility method instead of manual escaping
Fix inifnispan vector store for doKey() issues
Fix Redis vector store doKey() related issues
Typesense vector store doKey() fixes
Fix Couchbase vector store doKey() issues
Fix Elasticsearch doKey() implementation issues
Fix Opensearch vector store doKey() implementation issues
Maintain consistency for key handling across OpenSearch/ElasticSearch/Gemfire
- Move escaping of space into emitLuceneString
Fix RedisFilterExpressionConverter key handling
- Remove stripping of outer quotes
- Handle numberic fields when handling keys
Co-Authored-by: Eric Bottard <eric.bottard@broadcom.com>
Co-Authored-by: Soby Chacko <soby.chacko@broadcom.com>
Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>
This commit makes sure the conversationId equality test is properly handled and avoids dealing with escaping special characters like "'" in its value. Downstream VectorStore implementations and FilterExpressionConverter are then responsible for its proper escaping in the target query language. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
This commit introduces an upper limit to the accepted number of characters in a text line, to prevent excessive memory allocation when processing malformed pdf documents. This commit also puts an upper limit on the number of lines per page (computed from pdf content). Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
Make the default cache dir for transformer model more secure by using a non predictable, user-owned directory. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )