Minor improvements to path handling and access#333
Merged
rexm merged 1 commit intoHandlebars-Net:masterfrom Jan 2, 2020
Merged
Minor improvements to path handling and access#333rexm merged 1 commit intoHandlebars-Net:masterfrom
rexm merged 1 commit intoHandlebars-Net:masterfrom
Conversation
Give preference to string index get properties if one exists. Only trim a single pair of square brackets if both exist ([ at start of key and ] at end)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that path breaking respects square bracket escape characters so that objects with keys like
foo.barcan be accessed using{{ [foo.bar] }}(#328)Give preference to string index property getters if one exists, to avoid classes that implement
IEnumerable<object>whilst also having a string indexer (most notablyJObject) from being unable to be used with numeric keys. (#329)Only trim a single pair of square brackets from the key, and only if both exist (
[at start of key and]at end)