Skip to content

Fix for Issue #412#413

Merged
probot-auto-merge[bot] merged 6 commits intoHandlebars-Net:masterfrom
leniency:master
Jan 7, 2021
Merged

Fix for Issue #412#413
probot-auto-merge[bot] merged 6 commits intoHandlebars-Net:masterfrom
leniency:master

Conversation

@leniency
Copy link
Copy Markdown
Contributor

@leniency leniency commented Jan 7, 2021

Unit test and fix for issue #412 - The ReflectionMemberAccessor throws an exception when accessing value type members. The internal CreateGetDelegate method must specify pass-by-reference for these types.

Comment thread source/Handlebars/MemberAccessors/ReflectionMemberAccessor.cs Outdated
- Matched sort order for 'using'
@leniency
Copy link
Copy Markdown
Contributor Author

leniency commented Jan 7, 2021

Arg, sorry for the last commit - wasn't paying attention and missed that Visual Studio updated the sln file and also normalized all the line endings in that last commit. I'll see if I can get it removed and just the delegate line fixed.

Edit: Okay, reverted and cleaner commit added.

@oformaniuk
Copy link
Copy Markdown
Member

oformaniuk commented Jan 7, 2021

I've finally fixed broken Github Actions. Can you please rebase your branch on top of the latest master?

Edit: Did it on my own through Github UI

@oformaniuk oformaniuk added the merge Marks PRs that should be automatically merged label Jan 7, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@probot-auto-merge probot-auto-merge Bot merged commit c82a3b0 into Handlebars-Net:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug merge Marks PRs that should be automatically merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessing struct properties throws exception in ReflectionMemberAccessor

2 participants