-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: factorise output management #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| using ProjGraph.Lib.Core.Abstractions; | ||
|
|
||
| namespace ProjGraph.Cli.Infrastructure; | ||
|
|
||
| /// <summary> | ||
| /// Provides a reusable helper for writing rendered diagram output either to a file or to the console. | ||
| /// </summary> | ||
| /// <param name="console">The output console for writing results.</param> | ||
| /// <param name="fileSystem">The file system abstraction for disk operations.</param> | ||
| internal sealed class DiagramOutputWriter(IOutputConsole console, IFileSystem fileSystem) | ||
| { | ||
| /// <summary> | ||
| /// Writes the rendered diagram to the specified output file, or to the console if no file path is given. | ||
| /// </summary> | ||
| /// <param name="rendered">The rendered diagram string to write.</param> | ||
| /// <param name="outputPath"> | ||
| /// The optional file path to write to. When <see langword="null"/>, the output is written to the console. | ||
| /// </param> | ||
| /// <param name="cancellationToken">A token to monitor for cancellation requests.</param> | ||
| public async Task WriteAsync(string rendered, string? outputPath, CancellationToken cancellationToken) | ||
| { | ||
| if (outputPath is not null) | ||
| { | ||
| var directory = fileSystem.GetDirectoryName(outputPath); | ||
| if (!string.IsNullOrEmpty(directory)) | ||
| { | ||
| fileSystem.CreateDirectory(directory); | ||
| } | ||
|
|
||
| await fileSystem.WriteAllTextAsync(outputPath, rendered, cancellationToken); | ||
| console.WriteInfo($"Saved to {outputPath}"); | ||
| } | ||
| else | ||
| { | ||
| console.WriteLine(rendered); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Determines whether the rendered output should be wrapped in a Markdown fence, | ||
| /// based on the output file extension. Files ending in <c>.mmd</c> are not wrapped. | ||
| /// When writing to the console (no output path), the output is wrapped. | ||
| /// </summary> | ||
| /// <param name="outputPath">The optional output file path.</param> | ||
| /// <returns><see langword="true"/> if the output should be wrapped in a Markdown fence; otherwise, <see langword="false"/>.</returns> | ||
| public static bool ShouldWrapInMarkdownFence(string? outputPath) | ||
| { | ||
| return outputPath?.EndsWith(".mmd", StringComparison.OrdinalIgnoreCase) is not true; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.