Skip to content

fix: register DiagramOutputWriter in CLI integration test helper#39

Merged
HandyS11 merged 3 commits intochore/fix-duplication-on-clifrom
copilot/sub-pr-38
Feb 24, 2026
Merged

fix: register DiagramOutputWriter in CLI integration test helper#39
HandyS11 merged 3 commits intochore/fix-duplication-on-clifrom
copilot/sub-pr-38

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

  • Add DiagramOutputWriter singleton registration to CliTestHelpers.CreateApp()
  • Remove UTF-8 BOM from DiagramOutputWriter.cs to fix dotnet format --verify-no-changes CHARSET error

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on output management refactor fix: register DiagramOutputWriter in CLI integration test helper Feb 24, 2026
Copilot AI requested a review from HandyS11 February 24, 2026 09:42
@HandyS11 HandyS11 marked this pull request as ready for review February 24, 2026 09:43
Copilot AI review requested due to automatic review settings February 24, 2026 09:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a dependency injection issue in the CLI integration test helper that was causing all CLI integration tests to fail. The DiagramOutputWriter service, which is injected into all three CLI commands (VisualizeCommand, ErdCommand, and ClassDiagramCommand), was registered in the production application but missing from the test setup.

Changes:

  • Added DiagramOutputWriter singleton registration to the CLI test helper's CreateApp() method to match the production DI configuration in Program.cs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HandyS11
Copy link
Copy Markdown
Owner

@copilot the CI just failled with this error

Run dotnet format ProjGraph.slnx --no-restore --verify-no-changes
D:\a\ProjGraph\ProjGraph\src\ProjGraph.Cli\Infrastructure\DiagramOutputWriter.cs(1,1): error CHARSET: Fix file encoding. [D:\a\ProjGraph\ProjGraph\src\ProjGraph.Cli\ProjGraph.Cli.csproj]
Error: Process completed with exit code 1.

…at check

Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 24, 2026

@copilot the CI just failled with this error

Run dotnet format ProjGraph.slnx --no-restore --verify-no-changes
...

Fixed in commit e4b3f0aDiagramOutputWriter.cs had a UTF-8 BOM which caused the CHARSET error. Stripped the BOM so the file is now plain UTF-8.

@HandyS11 HandyS11 merged commit d22de3c into chore/fix-duplication-on-cli Feb 24, 2026
3 checks passed
@HandyS11 HandyS11 deleted the copilot/sub-pr-38 branch February 24, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants