Handle XmlException in ResolveCentralPackageVersion#41
Merged
HandyS11 merged 2 commits into008-nuget-package-renderingfrom Feb 24, 2026
Merged
Handle XmlException in ResolveCentralPackageVersion#41HandyS11 merged 2 commits into008-nuget-package-renderingfrom
HandyS11 merged 2 commits into008-nuget-package-renderingfrom
Conversation
Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on NuGet package rendering PR
Handle XmlException in ResolveCentralPackageVersion
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the core project parsing logic to be more resilient when resolving Central Package Management versions from Directory.Packages.props, specifically ensuring malformed XML doesn’t crash the directory-walk resolution.
Changes:
- Extend the exception filter in
ResolveCentralPackageVersionto also handleXmlException. - Add
System.Xmlimport to support the new exception type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectRootElement.Open()can throwXmlExceptionon malformedDirectory.Packages.propsfiles, but the catch filter inResolveCentralPackageVersiononly coveredIOExceptionandInvalidOperationException, causing an unhandled exception instead of continuing the directory tree walk.Changes
ProjectParser.cs: AddedXmlExceptionto the exception filter, matching the pattern already used inBuildGraphUseCase✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.