Handle stale settings registry on save#30
Merged
Conversation
a1a0514 to
75d7f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Catch settings save failures so the settings webview no longer remains stuck on
Saving....\n- PersistopenaiBaseUrlthrough extension globalState when VS Code's current window still has a stale configuration registry and rejectsgitRoast.openaiBaseUrl.\n- Read the fallback value in both the settings panel and runtime roast configuration, so saves work before a window reload.\n- Keep non-fallback configuration update failures visible as webview errors.\n- Clarify stored API key fields: key values remain hidden, blank fields keep saved keys, and pasted values replace them.\n- Add OpenAI request format selection withauto, Responses API, and Chat Completions support for OpenAI-compatible gateways.\n- Improve timeout diagnostics with provider, sanitized URL, model, and timeout budget.\n- Add regression coverage for stale registry fallback behavior, stored API key guidance, and Chat Completions requests.\n- Bump the VSIX build to0.0.11.\n\n## Verification\n-npx vitest run src/configuration.test.ts src/aiClients.test.ts src/settings/settingsUpdate.test.ts src/settings/settingsHtml.test.ts\n-npm run check\n-npm run package\n- Verifiedgit-roast-0.0.11.vsixcontains version0.0.11,gitRoast.openaiRequestFormat, Chat Completions request code, fallback persistence/runtime code, and visible stored-key guidance.\n- Installedgit-roast-0.0.11.vsixlocally and verified VS Code reportsgit-roast.git-roast@0.0.11.\n- Local user settings now explicitly setgitRoast.openaiRequestFormattochatCompletionsforhttps://llm.vibeprogramminglab.com/v1.\n\nFixes #29\nFixes #31\nFixes #32\nFixes #33