Skip to content

Handle stale settings registry on save#30

Merged
Hanjo92 merged 3 commits into
mainfrom
codex/fix-settings-save-registration-error
Jun 3, 2026
Merged

Handle stale settings registry on save#30
Hanjo92 merged 3 commits into
mainfrom
codex/fix-settings-save-registration-error

Conversation

@Hanjo92
Copy link
Copy Markdown
Owner

@Hanjo92 Hanjo92 commented Jun 3, 2026

Summary\n- Catch settings save failures so the settings webview no longer remains stuck on Saving....\n- Persist openaiBaseUrl through extension globalState when VS Code's current window still has a stale configuration registry and rejects gitRoast.openaiBaseUrl.\n- Read the fallback value in both the settings panel and runtime roast configuration, so saves work before a window reload.\n- Keep non-fallback configuration update failures visible as webview errors.\n- Clarify stored API key fields: key values remain hidden, blank fields keep saved keys, and pasted values replace them.\n- Add OpenAI request format selection with auto, Responses API, and Chat Completions support for OpenAI-compatible gateways.\n- Improve timeout diagnostics with provider, sanitized URL, model, and timeout budget.\n- Add regression coverage for stale registry fallback behavior, stored API key guidance, and Chat Completions requests.\n- Bump the VSIX build to 0.0.11.\n\n## Verification\n- npx vitest run src/configuration.test.ts src/aiClients.test.ts src/settings/settingsUpdate.test.ts src/settings/settingsHtml.test.ts\n- npm run check\n- npm run package\n- Verified git-roast-0.0.11.vsix contains version 0.0.11, gitRoast.openaiRequestFormat, Chat Completions request code, fallback persistence/runtime code, and visible stored-key guidance.\n- Installed git-roast-0.0.11.vsix locally and verified VS Code reports git-roast.git-roast@0.0.11.\n- Local user settings now explicitly set gitRoast.openaiRequestFormat to chatCompletions for https://llm.vibeprogramminglab.com/v1.\n\nFixes #29\nFixes #31\nFixes #32\nFixes #33

@Hanjo92 Hanjo92 force-pushed the codex/fix-settings-save-registration-error branch from a1a0514 to 75d7f49 Compare June 3, 2026 13:48
@Hanjo92 Hanjo92 merged commit da7164d into main Jun 3, 2026
1 check passed
@Hanjo92 Hanjo92 mentioned this pull request Jun 3, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant