Fix inet_addr#67
Merged
stepcut merged 1 commit intoHappstack:masterfrom May 27, 2021
Merged
Conversation
This breaks with modern Network libraries and I don't see how it ever worked. getAddrInfo takes an optional port number (or named port) in that argument. "tcp" is not a port. Passing Nothing suffices, since we're just getting the hostAddress and don't care about the port.
Contributor
Author
|
(note: this only occurs in the |
Member
|
Mysterious. Perhaps on some platforms in the past an invalid service name was treated the same as passing NULL. |
Member
|
on hackage as happstack-server-7.7.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks with modern Network libraries and I don't see how it ever worked. getAddrInfo takes an optional port number (or named port) in that argument. "tcp" is not a port. Passing Nothing suffices, since we're just getting the hostAddress and don't care about the port.