feat(randomness): submit drands asap#590
Merged
GabrielMartinezRodriguez merged 4 commits intomasterfrom Apr 28, 2025
Merged
Conversation
This was referenced Apr 8, 2025
Merged
Merged
Merged
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8674501 to
9ae1c90
Compare
2ea8352 to
fd5421a
Compare
9ae1c90 to
8bcf5c1
Compare
fd5421a to
c75d0b7
Compare
8bcf5c1 to
384bd3f
Compare
c75d0b7 to
a572b9a
Compare
384bd3f to
40004ff
Compare
a572b9a to
f56fed2
Compare
40004ff to
7d347c2
Compare
f56fed2 to
ffc92f9
Compare
7d347c2 to
0632195
Compare
ee8889a to
513f974
Compare
2343ce3 to
9ba9b58
Compare
513f974 to
2bf6dd1
Compare
9ba9b58 to
924b418
Compare
2bf6dd1 to
544cb2d
Compare
not-reed
reviewed
Apr 14, 2025
apps/randomness/src/DrandService.ts
Outdated
|
|
||
| drand.transactionSubmitted() | ||
|
|
||
| this.drandRepository.updateDrand(drand).catch((error) => { |
Contributor
Author
There was a problem hiding this comment.
changed
| await this.collectTransactions(transactionsBatch) | ||
| } | ||
|
|
||
| @TraceMethod("txm.transaction-collector.collect-transactions") |
Contributor
There was a problem hiding this comment.
i have quite conflicted feelings about decorators 😄
924b418 to
c73f432
Compare
544cb2d to
22f4cb1
Compare
This was referenced Apr 21, 2025
Merged
norswap
reviewed
Apr 24, 2025
| } | ||
|
|
||
| @TraceMethod("txm.transaction-collector.collect-transactions") | ||
| public async collectTransactions(transactionsBatch: Transaction[]) { |
Collaborator
There was a problem hiding this comment.
Should we call this sendTransactions? Since if A passes something to B, B is collecting from A. But in this case, A is passing transactions to B, so it's A doing the action :)
norswap
approved these changes
Apr 24, 2025
c73f432 to
c95e27e
Compare
22f4cb1 to
ef46a34
Compare
c95e27e to
445f322
Compare
12eeef7 to
f3644b3
Compare
11 tasks
f3644b3 to
280a889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds a mechanism to the transaction manager to allow submitting transactions without waiting for a new block to arrive. Additionally, this is implemented in the randomness service to submit drands as soon as they arrive. Thanks to this mechanism, we've achieved a 100% success rate in the sequential randomness of the Randomness contract
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >
< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
comments.
in a Markdown document.
packages/coreandpackages/react), see here for more info.