Skip to content

chore(qm): extend BEACON_KINDS with council-request and autofix kinds#10

Merged
ctwoodwa merged 1 commit into
mainfrom
chore-qm-daemon-beacon-kinds-extension
May 25, 2026
Merged

chore(qm): extend BEACON_KINDS with council-request and autofix kinds#10
ctwoodwa merged 1 commit into
mainfrom
chore-qm-daemon-beacon-kinds-extension

Conversation

@ctwoodwa
Copy link
Copy Markdown
Contributor

@ctwoodwa ctwoodwa commented May 25, 2026

Summary

  • Adds council-request to BEACON_KINDS — was triggering false-positive "mis-named" findings for engineer-council-request-* beacons on every daemon run
  • Adds autofix to BEACON_KINDS — qm-daemon's own --auto-fix output beacon would have been flagged as mis-named by its own Check 3 scan
  • Adds inline comments explaining each kind's purpose and origin

Test plan

  • Regex unit-tested locally: engineer-council-request-2026-05-22T0901Z-signal-bridge-36-journal-entries.md now matches
  • python3 qm-daemon.py --dry-run --check beacon-naming no longer reports council-request false-positives
  • Pre-flight git log -1 --format=%B | grep -E '[A-Za-z]#[0-9]' returns nothing
  • CI green

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced beacon naming validation to recognize additional beacon type identifiers, reducing false positive mis-naming alerts for inbox beacon files.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a9133f3a-8a7e-4117-930b-d97985be9e0e

📥 Commits

Reviewing files that changed from the base of the PR and between 728ce12 and 0a55eb0.

📒 Files selected for processing (1)
  • qm-daemon.py

📝 Walkthrough

Walkthrough

This pull request expands the BEACON_KINDS constant in qm-daemon.py to accept additional beacon type names. The beacon naming validator regex now recognizes attest, revival-context variants, tracking, pending-rearm, subagent-status, council-request, and autofix beacon kinds in addition to the original set.

Changes

Beacon Kind Validation Expansion

Layer / File(s) Summary
Beacon kinds constant update
qm-daemon.py
BEACON_KINDS tuple expanded from a narrower set to include additional beacon kind alternatives (attest, revival-context variants, tracking, pending-rearm, subagent-status, council-request, and autofix) while retaining original kinds, directly affecting which inbox beacon filenames pass the naming regex validator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 Beacons now fly far and wide,
Attest and track with renewed pride,
The validator opens its welcoming door,
For council requests and autofix, and more!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore-qm-daemon-beacon-kinds-extension

Comment @coderabbitai help to get the list of available commands and usage tips.

Add two missing beacon kinds to the BEACON_KINDS constant used by the
Check 3 naming validator:

- council-request: filed by engineer/fed/po-* when requesting a council
  SPOT-CHECK (e.g. engineer-council-request-*). Was triggering false-
  positive "mis-named" findings on every daemon run.

- autofix: produced by the daemon itself (qm-daemon-status-*-autofix.md)
  when --auto-fix strips anatomy contamination. Would have been flagged
  as mis-named by its own Check 3 scan.

Added inline comments to the BEACON_KINDS block explaining each kind's
purpose and origin.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ctwoodwa ctwoodwa force-pushed the chore-qm-daemon-beacon-kinds-extension branch from 8bb2277 to 0a55eb0 Compare May 25, 2026 15:18
@ctwoodwa ctwoodwa enabled auto-merge (squash) May 25, 2026 15:19
@ctwoodwa ctwoodwa merged commit 1377bb7 into main May 25, 2026
2 of 3 checks passed
@ctwoodwa ctwoodwa deleted the chore-qm-daemon-beacon-kinds-extension branch May 25, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant