chore(qm): extend BEACON_KINDS with council-request and autofix kinds#10
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request expands the ChangesBeacon Kind Validation Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Add two missing beacon kinds to the BEACON_KINDS constant used by the Check 3 naming validator: - council-request: filed by engineer/fed/po-* when requesting a council SPOT-CHECK (e.g. engineer-council-request-*). Was triggering false- positive "mis-named" findings on every daemon run. - autofix: produced by the daemon itself (qm-daemon-status-*-autofix.md) when --auto-fix strips anatomy contamination. Would have been flagged as mis-named by its own Check 3 scan. Added inline comments to the BEACON_KINDS block explaining each kind's purpose and origin. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
8bb2277 to
0a55eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
council-requesttoBEACON_KINDS— was triggering false-positive "mis-named" findings forengineer-council-request-*beacons on every daemon runautofixtoBEACON_KINDS— qm-daemon's own--auto-fixoutput beacon would have been flagged as mis-named by its own Check 3 scanTest plan
engineer-council-request-2026-05-22T0901Z-signal-bridge-36-journal-entries.mdnow matchespython3 qm-daemon.py --dry-run --check beacon-namingno longer reportscouncil-requestfalse-positivesgit log -1 --format=%B | grep -E '[A-Za-z]#[0-9]'returns nothing🤖 Generated with Claude Code
Summary by CodeRabbit