Gaiter#1599
Conversation
github-actions
Bot
added
S: Untriaged
Sprites
No C#
YML
size/M
and removed
S: Untriaged
labels
|
so many issues o.o |
|
Unhandled exception. NUnit.Framework.AssertionException: CLIENT: 10.310s [ERRO] eng: Exception whilst loading prototypes from /Prototypes/_HL/Entities/Clothing/Neck/gaiter.yml: |
|
ooh i forgot to review linter, il fix it when i wake up |
|
Ok, fixes should be good, hopefully! |
|
Does this add the cool cloth wraps that work as gloves too? |
|
yes |
… load (#1662) PR #1599 (Gaiter) renamed several entity prototypes (e.g. ClothingShoesClothwrap -> ClothingClothWrap, BorgModule* renames, ColCom encryption keys) and added the mapping to a new Resources/hl_migration.yml. However MapMigrationSystem only loaded /migration.yml and /nf_migration.yml, so the HL renames were never applied at map load time. Any map referencing a renamed prototype (including Resources/Maps/_HL/colcomm.yml) failed to load with a generic 'An error occurred while loading map' message. Add /hl_migration.yml to the MigrationFiles list so HL renames are honored. Also tighten the AddColcomm error logs to include the offending map path and the expected vs actual parent, so this class of failure is diagnosable from the server log without engine-level debugging.
* Start Port Starlight Languages #1253 * add some missing newlines * emergency fixes * Continue Port Starlight Languages #1253 * additional fixes * doing this one file at a time apparently * guh * Finish Port Starlight Languages #1253 * fix to make it work * remaining necessary port + linter fix for makesentient refactor * Port Starlight Language Fixes #1412 * Port Starlight Language Patch #1414 * Port Starlight PR #1416 & #1421 * Port Starlight Thaveyan Language + Thaven Speech Verbs PR #1440 * Port Starlight Language Tweaks #1446 * Port Starlight Silicon Language Base PR #1454 * Port Starlight Vulpkanin, Shadekin, & Vox Language Icons PR #1480 * Port Starlight PR #1512 & #1533 * Port Starlight Language Trait Tweaks #1599 * Port Starlight PR #1453, #1611, #1673, #1854, #2231, & #2291 * Port Starlight PR #1554, #1617, #2277, #2715 * Port Starlight PR #3019 & #3796 * two quick fixes * Port Starlight Translator Refactor PR #4242 * some more fixes * Port Starlight Animals Understand Common PR #4340 * Port Starlight PR #1509 + linter fix * port necessary files from Starlight PR #2935 to make icons work * minor optimization tweaks + enable chatbox icons + mouse language color * no idea what I'm doing * protogen tweak * synth fix * add language icon display toggle
3 participants
About the PR
Adds a bunch of new Gaiters, that can be folded (on mask or neck)
Replace old footwarps with Clothwarps from Starlight, this has some slight improvement and... HAND WARPS!
Why / Balance
Drip?
Technical details
Just yml changes, however remove the old Gaiter/Clothwarps.
How to test
Spawn Gaiter, profit.
Spawn ClothWarps... Profit.
Media
Breaking changes
Migration Files updated and any refs.
Changelog
🆑 Shades