Revert shadekin

[fenndragon]

About the PR

Reverts the abysmal way the shadekin and nullspace got butchered recently and anomalies being implemented so that shadekin, the anomaly role, and the dark can be implemented in a more cohesive and solid state in the future.

Why / Balance

Technical details

How to test

Media

Breaking changes

Changelog

🆑

• remove: Removed nullphase/shadekin changes
• remove: temporarily removed the Anomaly job role

[ShadesMars]

Dont rever it to my old previous outated code, just because of some bugs that was fixed.
Talk to me instead in dev channel.

[Dhizi]

So had this one actually gotten talked to about like Shades asked? Or what was the consensus to us who weren't in the know case-wise of what happened?

[NotLivyathan]

So had this one actually gotten talked to about like Shades asked? Or what was the consensus to us who weren't in the know case-wise of what happened?

It was never up for discussion.

[Dhizi]

I try to be considerate to all, but it would be definitely nice to have the same given back in equal, or at least get better transparency on actions.

Or at minimum, a tl;dr of what changed because i'm under a decent assumption that this isn't a -small- revert, especially with the author saying that reverting this would take us back to outdated code that was supposedly bugfixed.

[Magniras]

Oh, did the shadekin creator see and complain?

[Dhizi]

Oh, did the shadekin creator see and complain?

I feel like 'complain' is definitely the wrong word, given the fact they were actively testing, bugfixing, balancing and doing a lot of hard work to reign in areas that were problematic. They've been willingly open to do what they can to fix things and listen, let alone openly communicate on these things. The author for anomaly/and the shadekin PR implementations from other places asked above to just be -talked- to. That is not unreasonable to do, I just wanted to know if it happened or not.

[Magniras]

Not Shades, uh, whats their name. Verysoft. Casey.

[Dhizi]

Not Shades, uh, whats their name. Verysoft. Casey.

Wuh? No??? I specified Shades, the one who authored the anomaly role and all the Shadekin PR fixes here. I don't think I'd know if that person who as far as i'm aware isn't on this server has complained or not. I only asked if there'd been any communication at all on the revert given its size and effort and fact it was being actively fixed, or if we just ignored the authors request to just be -talked- to. You know. Basic common decency at minimum. I HOPE (or at least have optimism) we did that.

[Magniras]

Yeah, I wasn't asking you? I was asking in general. Also they're on server.

[Dhizi]

Yeah, I wasn't asking you? I was asking in general. Also they're on server.

Oh apologies. I keep forgetting the way github lays out responses and stuff, sometimes it's hard to know who someone's talking to.

But unless they say something, i'm going to assume not?

[IngvarJackal]

Very curious pull request. I will just leave those quotes here for the future reference.

[ShadesMars]

I see that instead waiting because im sleeping you go forward with this and revert it all.

Even when the previous PR was going to have the flashers changes you wanted.

[IrkallaEpsilon]

Shadekin changes cannot be "abysmal" at all. Why you ask? Well its pretty simple you said it yourself.

As you previously stated and heavily enforced: Shadekin CANNOT interact with Abyssals.

[Dhizi]

Shadekin changes cannot be "abysmal" at all. Why you ask? Well its pretty simple you said it yourself.

As you previously stated and heavily enforced: Shadekin CANNOT interact with Abyssals.

They meant "the way this got put in was abysmal (bad)".

They didn't mean anything relevant to interacting with Abyssal entities.

[IrkallaEpsilon]

Shadekin changes cannot be "abysmal" at all. Why you ask? Well its pretty simple you said it yourself.
As you previously stated and heavily enforced: Shadekin CANNOT interact with Abyssals.

They meant "the way this got put in was abysmal (bad)".

They didn't mean anything relevant to interacting with Abyssal entities.

Well aware of it.

[Dhizi]

Shadekin changes cannot be "abysmal" at all. Why you ask? Well its pretty simple you said it yourself.
As you previously stated and heavily enforced: Shadekin CANNOT interact with Abyssals.

They meant "the way this got put in was abysmal (bad)".
They didn't mean anything relevant to interacting with Abyssal entities.

Well aware of it.

Then I am utterly confused. Sarcasm??????