Skip to content

fix: configs in deploy#234

Merged
HardMax71 merged 2 commits intomainfrom
fix/configs
Feb 24, 2026
Merged

fix: configs in deploy#234
HardMax71 merged 2 commits intomainfrom
fix/configs

Conversation

@HardMax71
Copy link
Copy Markdown
Owner

@HardMax71 HardMax71 commented Feb 24, 2026

Summary by cubic

Improves Loki stability in deploys by fixing the readiness check and hardening retention deletion behavior. Disables the unused ruler API and sets local rule storage.

  • Bug Fixes
    • docker-compose: readiness check now asserts "ready"; increased retries (12) and start period (20s) to avoid false restarts.
    • loki-config: disabled ruler API and set local rule storage at /loki/rules.
    • loki compactor: uses filesystem for delete_request_store to make retention deletes reliable.

Written for commit 3f356d5. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Enhanced health monitoring for the Loki service with improved readiness detection
    • Extended startup grace period to allow more reliable service initialization
    • Configured rule storage backend for improved operational stability

Copilot AI review requested due to automatic review settings February 24, 2026 23:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HardMax71 HardMax71 merged commit fb81eb9 into main Feb 24, 2026
8 of 9 checks passed
@HardMax71 HardMax71 deleted the fix/configs branch February 24, 2026 23:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b03558f and 3f356d5.

📒 Files selected for processing (2)
  • backend/loki/loki-config.yaml
  • docker-compose.yaml

📝 Walkthrough

Walkthrough

Backend Loki configuration now includes a ruler component with API disabled and local storage directory, while the compactor uses filesystem-based delete request storage. Docker Compose healthcheck for Loki was enhanced with explicit readiness verification and extended timing parameters for improved resilience.

Changes

Cohort / File(s) Summary
Loki Configuration
backend/loki/loki-config.yaml
Added ruler configuration block (API disabled, local storage at /loki/rules) and compactor delete request store configuration (filesystem backend).
Docker Healthcheck
docker-compose.yaml
Updated Loki service healthcheck to use grep-based readiness verification for "ready" string, increased retry attempts from 10 to 12, and extended start period from 15s to 20s.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A ruler now governs the Loki domain,
With local storage to lighten the strain,
Compactor deletes with filesystem grace,
While Docker checks readiness at a steadier pace,
More retries, more time—resilience's refrain! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/configs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants