Skip to content

fix: user seed container adding path to config files#262

Merged
HardMax71 merged 1 commit intomainfrom
fix/seed-users-creds
Mar 3, 2026
Merged

fix: user seed container adding path to config files#262
HardMax71 merged 1 commit intomainfrom
fix/seed-users-creds

Conversation

@HardMax71
Copy link
Copy Markdown
Owner

@HardMax71 HardMax71 commented Mar 3, 2026

Summary by cubic

Fixes the user seeding container by mounting the backend app and scripts directories so Python can import scripts.seed_users. Restores seeding when running via docker-compose.

  • Bug Fixes
    • Added read-only volumes: ./backend/app -> /app/app and ./backend/scripts -> /app/scripts. Existing config.toml mount unchanged.

Written for commit 2b24bff. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated Docker service configuration to enhance application runtime environment setup and access.

Copilot AI review requested due to automatic review settings March 3, 2026 21:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1205cf4 and 2b24bff.

📒 Files selected for processing (1)
  • docker-compose.yaml

📝 Walkthrough

Walkthrough

The docker-compose.yaml file has been updated to include two read-only bind mounts for the user-seed service: mounting the backend/app directory to /app/app and backend/scripts to /app/scripts. These additions provide the service with access to application and script files at runtime.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yaml
Added two read-only bind mounts to the user-seed service: backend/app mounted to /app/app:ro and backend/scripts mounted to /app/scripts:ro. These enable the service to access application code and scripts during execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hops through the docker-compose with glee,
Read-only mounts, secure as can be!
App and scripts, now bound with care,
In containers of code, we share and share! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'adding path to config files' but the actual changes add read-only mounts for backend/app and backend/scripts directories, not config files specifically. Clarify the title to accurately reflect that read-only mounts for app and scripts directories are being added, or confirm if these directories contain the config files being referenced.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/seed-users-creds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Docker Compose user-seed one-shot container to mount the backend source directories needed to run scripts.seed_users consistently with the rest of the stack.

Changes:

  • Mount ./backend/app into /app/app for app.* imports during seeding.
  • Mount ./backend/scripts into /app/scripts so python -m scripts.seed_users can resolve the scripts package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HardMax71 HardMax71 merged commit f61b4ba into main Mar 3, 2026
20 checks passed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
backend-e2e 83.22% <ø> (+0.01%) ⬆️
backend-unit 67.91% <ø> (ø)
frontend-unit 86.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend 90.07% <ø> (ø)
Frontend 86.86% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants