Skip to content

Fix/seed users creds#263

Merged
HardMax71 merged 2 commits intomainfrom
fix/seed-users-creds
Mar 3, 2026
Merged

Fix/seed users creds#263
HardMax71 merged 2 commits intomainfrom
fix/seed-users-creds

Conversation

@HardMax71
Copy link
Copy Markdown
Owner

@HardMax71 HardMax71 commented Mar 3, 2026

Summary by cubic

Use MongoDB credentials in the healthcheck and mount backend code/scripts for the user-seed service to fix seeding with auth and ensure reliable startup.

  • Bug Fixes
    • Healthcheck now authenticates with MONGO_USER/MONGO_PASSWORD (defaults root/rootpassword) against the admin DB.
    • User-seed service mounts backend/app and backend/scripts read-only so scripts.seed_users and config.toml are available at runtime.

Written for commit 3a2736b. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Enhanced MongoDB health check with authentication requirements
    • Updated service configuration for improved isolation and security

Copilot AI review requested due to automatic review settings March 3, 2026 22:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f61b4ba and 3a2736b.

📒 Files selected for processing (1)
  • docker-compose.yaml

📝 Walkthrough

Walkthrough

Updated the MongoDB healthcheck in Docker Compose to include authentication credentials and added read-only volume mounts to the user-seed service for accessing application and script directories.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yaml
Updated MongoDB healthcheck with authentication parameters (user, password, authenticationDatabase). Added read-only volume mounts for app and scripts directories to user-seed service.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a bound, through config we go,
MongoDB now needs credentials to show.
Read-only volumes, safe paths aligned,
Seeds planted gently, no secrets to find! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix/seed users creds' is directly related to the main changes in the pull request, which involve updating MongoDB authentication credentials in the healthcheck and augmenting the user-seed service configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/seed-users-creds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docker-compose.yaml">

<violation number="1" location="docker-compose.yaml:69">
P1: Use exec-form healthcheck instead of shell-form to avoid shell parsing of credentials; current command can fail for valid passwords containing special characters.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread docker-compose.yaml
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the local Docker Compose stack to support authenticated MongoDB health checks and ensures the user seeding job runs against the checked-out backend code.

Changes:

  • Update the mongo container healthcheck to authenticate with the configured MongoDB root credentials.
  • Mount ./backend/app and ./backend/scripts into the user-seed container (read-only) so it executes local code when seeding users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yaml
@HardMax71 HardMax71 merged commit 88173da into main Mar 3, 2026
20 checks passed
@HardMax71 HardMax71 deleted the fix/seed-users-creds branch March 3, 2026 22:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
backend-e2e 83.21% <ø> (ø)
backend-unit 67.91% <ø> (ø)
frontend-unit 86.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend 90.07% <ø> (ø)
Frontend 86.86% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants